Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 653573003: Move ShellAccessTokenStore away from //content/shell/geolocation/. (Closed)

Created:
6 years, 2 months ago by Peter Beverloo
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move ShellAccessTokenStore away from //content/shell/geolocation/. It's odd to have a directory specifically for this, since the other directories in //content/shell/ refer to the process they're in. BUG= Committed: https://crrev.com/11d5f564c7bc634967edf4b06c801d46cfa399f5 Cr-Commit-Position: refs/heads/master@{#300973}

Patch Set 1 #

Patch Set 2 : sync gyp and gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -111 lines) Patch
M content/content_shell.gypi View 4 chunks +4 lines, -4 lines 0 comments Download
M content/shell/BUILD.gn View 1 4 chunks +4 lines, -4 lines 0 comments Download
A + content/shell/browser/shell_access_token_store.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/browser/shell_access_token_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 2 chunks +1 line, -1 line 0 comments Download
D content/shell/geolocation/shell_access_token_store.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/shell/geolocation/shell_access_token_store.cc View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Peter Beverloo
mkwst: PTAL mvanouwerkerk: FYI I found this while touching some other files :-).
6 years, 2 months ago (2014-10-23 15:31:04 UTC) #2
Michael van Ouwerkerk
lgtm
6 years, 2 months ago (2014-10-23 16:04:07 UTC) #3
Mike West
LGTM 2.
6 years, 2 months ago (2014-10-23 18:57:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653573003/20001
6 years, 2 months ago (2014-10-23 21:52:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-23 23:12:43 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 23:13:20 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/11d5f564c7bc634967edf4b06c801d46cfa399f5
Cr-Commit-Position: refs/heads/master@{#300973}

Powered by Google App Engine
This is Rietveld 408576698