Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 653533005: gpu: Add missing ScopedRenderTo (Closed)

Created:
6 years, 2 months ago by boliu
Modified:
6 years, 2 months ago
Reviewers:
no sievers
CC:
chromium-reviews, piman+watch_chromium.org, oetuaho-nv
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gpu: Add missing ScopedRenderTo MailboxSynchronizer which is used by Android WebView depends on them for correct synchronization. BUG=424293 Committed: https://crrev.com/2e7d8a7a6d19a1581ae7896aa41e64e2a2b37a1e Cr-Commit-Position: refs/heads/master@{#299969}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
boliu
6 years, 2 months ago (2014-10-16 18:43:35 UTC) #2
no sievers
lgtm with 1 comment https://codereview.chromium.org/653533005/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/653533005/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode4369 gpu/command_buffer/service/gles2_cmd_decoder.cc:4369: ScopedRenderTo do_render(framebuffer_state_.bound_draw_framebuffer.get()); ScopedRenderTo do_render(framebuffer);
6 years, 2 months ago (2014-10-16 18:53:18 UTC) #3
boliu
https://codereview.chromium.org/653533005/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/653533005/diff/1/gpu/command_buffer/service/gles2_cmd_decoder.cc#newcode4369 gpu/command_buffer/service/gles2_cmd_decoder.cc:4369: ScopedRenderTo do_render(framebuffer_state_.bound_draw_framebuffer.get()); On 2014/10/16 18:53:18, sievers wrote: > ScopedRenderTo ...
6 years, 2 months ago (2014-10-16 19:04:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653533005/20001
6 years, 2 months ago (2014-10-16 19:05:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-16 20:35:26 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 20:36:07 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2e7d8a7a6d19a1581ae7896aa41e64e2a2b37a1e
Cr-Commit-Position: refs/heads/master@{#299969}

Powered by Google App Engine
This is Rietveld 408576698