Input type number should return SpinButtonRole from blink to chromium side to expose w correct role.

Input type number should return SpinButtonRole from blink to chromium side to expose w correct role.

This patch would return SpinButtonRole for input type number.

So, that input type attribute "number" could be exposed similar to ARIA role spinbutton.

This is in accordance with following http://rawgit.com/w3c/aria/master/html-aam/html-aam.html

BUG=385014

[shreeramk, 2014-10-12 18:51:18]

shreeram.k@samsung.com changed reviewers:
+ dglazkov@chromium.org, dmazzoni@chromium.org, mkwst@chromium.org

[shreeramk, 2014-10-12 18:51:19]

Please review.

This CL would be followed up by a Chromium side CL.

Thanks!

[Mike West, 2014-10-13 04:07:15]

The code change looks reasonable, but
accessibility/canvas-fallback-content-2.html is failing consistently. Please
take a look at that test.

[shreeramk, 2014-10-13 06:01:54]

On 2014/10/13 04:07:15, Mike West wrote:
> The code change looks reasonable, but
> accessibility/canvas-fallback-content-2.html is failing consistently. Please
> take a look at that test.

Its failing while <input type="number"> is inside a canvas. I looked into the
code. canvasHasFallbackContent() might be related but not able to figure out the
cause of failure.


Its failing for below three shouldBe():

shouldBe("axElement2.role", "axElement1.role");
FAIL axElement2.role should be AXRole: AXTextField. Was AXRole: AXNumber.

shouldBe("axElement2.stringValue", "axElement1.stringValue");
FAIL axElement2.stringValue should be AXValue: 123. Was AXValue: .

shouldBe("axElement2.intValue", "axElement1.intValue");
FAIL axElement2.intValue should be 123. Was 0.

[dmazzoni, 2014-10-13 07:51:43]

Let's call this NumberFieldRole rather than just NumberRole, to make it clear
that this role is for a field / control where you input a number, not just a
static number on the page. Otherwise lg.

[shreeramk, 2014-10-13 08:09:13]

On 2014/10/13 07:51:43, dmazzoni wrote:
> Let's call this NumberFieldRole rather than just NumberRole, to make it clear
> that this role is for a field / control where you input a number, not just a
> static number on the page. Otherwise lg.

Now its NumberFieldRole.

[dmazzoni, 2014-10-13 08:20:32]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2014-10-13 08:20:32]

lgtm

[commit-bot: I haz the power, 2014-10-13 08:21:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/653433002/150001

[shreeramk, 2014-10-13 08:42:58]

On 2014/10/13 08:21:23, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/653433002/150001

Still its failing
failures:
accessibility/canvas-fallback-content-2.html

[commit-bot: I haz the power, 2014-10-13 09:47:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-13 09:47:23]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)

[shreeramk, 2014-10-14 17:45:35]

On 2014/10/13 09:47:23, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_blink_rel on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)

@Dominic:

Any Inputs on this?

Its failing while <input type="number"> is inside a canvas. I looked into the
code. canvasHasFallbackContent() might be related but I am not getting any code
specific to input type number which could fix this.

[dmazzoni, 2014-10-15 13:38:55]

Inside a canvas, it'd be calling the AXNodeObject code, and outside it'll
be calling the AXRenderObject code - does that help?

On Tue, Oct 14, 2014 at 10:45 AM, <shreeram.k@samsung.com> wrote:

> On 2014/10/13 09:47:23, I haz the power (commit-bot) wrote:
>
>> Try jobs failed on following builders:
>>    linux_blink_rel on tryserver.blink
>>
>
> (http://build.chromium.org/p/tryserver.blink/builders/
> linux_blink_rel/builds/28947)
>
> @Dominic:
>
> Any Inputs on this?
>
> Its failing while <input type="number"> is inside a canvas. I looked into
> the
> code. canvasHasFallbackContent() might be related but I am not getting any
> code
> specific to input type number which could fix this.
>
> https://codereview.chromium.org/653433002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[shreeramk, 2014-10-15 14:07:54]

On 2014/10/15 13:38:55, dmazzoni wrote:
> Inside a canvas, it'd be calling the AXNodeObject code, and outside it'll
> be calling the AXRenderObject code - does that help?
 
But I have made the changes at both place to return the same role. Hence it
shouldn't fail. Isn't?

From below logs one thing is clear that input type number not within canvas is
behaving correctly, but the input type with in a canvas is returning AXNumber
instead of AXTextField

shouldBe("axElement2.role", "axElement1.role");
FAIL axElement2.role should be AXRole: AXTextField. Was AXRole: AXNumber.

shouldBe("axElement2.stringValue", "axElement1.stringValue");
FAIL axElement2.stringValue should be AXValue: 123. Was AXValue: .

shouldBe("axElement2.intValue", "axElement1.intValue");
FAIL axElement2.intValue should be 123. Was 0.



> On Tue, Oct 14, 2014 at 10:45 AM, <mailto:shreeram.k@samsung.com> wrote:
> 
> > On 2014/10/13 09:47:23, I haz the power (commit-bot) wrote:
> >
> >> Try jobs failed on following builders:
> >>    linux_blink_rel on tryserver.blink
> >>
> >
> > (http://build.chromium.org/p/tryserver.blink/builders/
> > linux_blink_rel/builds/28947)
> >
> > @Dominic:
> >
> > Any Inputs on this?
> >
> > Its failing while <input type="number"> is inside a canvas. I looked into
> > the
> > code. canvasHasFallbackContent() might be related but I am not getting any
> > code
> > specific to input type number which could fix this.
> >
> > https://codereview.chromium.org/653433002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:blink-reviews+unsubscribe@chromium.org.

[dmazzoni, 2014-10-15 15:10:35]

Part of the issue is that you're introducing a new role that's used in a layout
test, so until you update
content/shell/renderer/test_runner/web_ax_object_proxy.cc on the Chromium side,
it can't display the right string name for NumberFieldRole.

It'd be okay to disable this test temporarily by adding it to
LayoutTests/TestExpectations

However, it looks like you should fix stringValue and intValue to properly
support NumberFieldRole.

number1
PASS document.activeElement == element1 is true
number2
PASS document.activeElement == element2 is true
FAIL axElement2.role should be AXRole: AXTextField. Was AXRole: AXUnknown.
PASS axElement2.roleDescription is axElement1.roleDescription
PASS axElement2.title is axElement1.title
PASS axElement2.description is axElement1.description
PASS axElement2.helpText is axElement1.helpText
FAIL axElement2.stringValue should be AXValue: 123. Was AXValue: .
PASS axElement2.isEnabled is axElement1.isEnabled
PASS axElement2.isRequired is axElement1.isRequired
PASS axElement2.isChecked is axElement1.isChecked
FAIL axElement2.intValue should be 123. Was 0.
PASS axElement2.minValue is axElement1.minValue
PASS axElement2.maxValue is axElement1.maxValue











On 2014/10/15 14:07:54, shreeram.k wrote:
> On 2014/10/15 13:38:55, dmazzoni wrote:
> > Inside a canvas, it'd be calling the AXNodeObject code, and outside it'll
> > be calling the AXRenderObject code - does that help?
>  
> But I have made the changes at both place to return the same role. Hence it
> shouldn't fail. Isn't?
> 
> From below logs one thing is clear that input type number not within canvas is
> behaving correctly, but the input type with in a canvas is returning AXNumber
> instead of AXTextField
> 
> shouldBe("axElement2.role", "axElement1.role");
> FAIL axElement2.role should be AXRole: AXTextField. Was AXRole: AXNumber.
> 
> shouldBe("axElement2.stringValue", "axElement1.stringValue");
> FAIL axElement2.stringValue should be AXValue: 123. Was AXValue: .
> 
> shouldBe("axElement2.intValue", "axElement1.intValue");
> FAIL axElement2.intValue should be 123. Was 0.
> 
> 
> 
> > On Tue, Oct 14, 2014 at 10:45 AM, <mailto:shreeram.k@samsung.com> wrote:
> > 
> > > On 2014/10/13 09:47:23, I haz the power (commit-bot) wrote:
> > >
> > >> Try jobs failed on following builders:
> > >>    linux_blink_rel on tryserver.blink
> > >>
> > >
> > > (http://build.chromium.org/p/tryserver.blink/builders/
> > > linux_blink_rel/builds/28947)
> > >
> > > @Dominic:
> > >
> > > Any Inputs on this?
> > >
> > > Its failing while <input type="number"> is inside a canvas. I looked into
> > > the
> > > code. canvasHasFallbackContent() might be related but I am not getting any
> > > code
> > > specific to input type number which could fix this.
> > >
> > > https://codereview.chromium.org/653433002/
> > >
> > 
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:blink-reviews+unsubscribe@chromium.org.

[shreeramk, 2014-10-27 16:07:05]

I ll update this issue once I ll be back to office. Sorry for the delay.

[shreeramk, 2014-11-10 11:19:14]

On 2014/10/27 16:07:05, shreeramk wrote:
> I ll update this issue once I ll be back to office. Sorry for the delay.

I am facing problem in rebasing this CL. So, I'm continuing the same in this new
CL https://codereview.chromium.org/718433002/

Thanks :)