Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1872)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 65343006: Use TracingController for startup tracing (Closed)

Created:
7 years, 1 month ago by Xianzhu
Modified:
7 years, 1 month ago
Reviewers:
piman, nduca, Cris Neckar
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dsinclair+watch_chromium.org, jam
Visibility:
Public.

Description

Use TracingController for startup tracing This CL depends on https://codereview.chromium.org/66893003/ (which allows customized trace data file) and https://codereview.chromium.org/66193005/ (which removes TraceLog enable counting). BUG=none R=cdn@chromium.org, nduca@chromium.org, piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236362

Patch Set 1 : #

Patch Set 2 : Rebased #

Patch Set 3 : Rebase #

Patch Set 4 : #

Patch Set 5 : Fix monitoring browser test failure #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -121 lines) Patch
M base/debug/trace_event_impl.cc View 1 2 3 4 2 chunks +2 lines, -5 lines 0 comments Download
M components/tracing/child_trace_message_filter.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/tracing/child_trace_message_filter.cc View 1 2 3 4 5 4 chunks +8 lines, -14 lines 0 comments Download
M components/tracing/tracing_messages.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/browser_main_loop.h View 1 2 3 4 chunks +8 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 chunks +45 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/trace_controller_impl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/tracing/trace_controller_impl.cc View 6 chunks +2 lines, -63 lines 0 comments Download
M content/browser/tracing/trace_message_filter.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/tracing/trace_message_filter.cc View 5 chunks +7 lines, -4 lines 0 comments Download
M content/browser/tracing/tracing_controller_browsertest.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 2 3 4 7 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Xianzhu
7 years, 1 month ago (2013-11-09 00:48:40 UTC) #1
Cris Neckar
On 2013/11/09 00:48:40, Xianzhu wrote: IPC changes LGTM
7 years, 1 month ago (2013-11-14 02:07:09 UTC) #2
nduca
lgtm
7 years, 1 month ago (2013-11-15 23:08:38 UTC) #3
Xianzhu
Ping piman@ (for content/browser/...)
7 years, 1 month ago (2013-11-20 00:05:40 UTC) #4
piman
lgtm
7 years, 1 month ago (2013-11-20 00:46:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/65343006/120001
7 years, 1 month ago (2013-11-20 01:13:05 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=190519
7 years, 1 month ago (2013-11-20 02:30:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/65343006/120001
7 years, 1 month ago (2013-11-20 03:12:37 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=190585
7 years, 1 month ago (2013-11-20 05:04:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/65343006/740001
7 years, 1 month ago (2013-11-20 19:48:41 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=190904
7 years, 1 month ago (2013-11-20 20:33:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/65343006/1080001
7 years, 1 month ago (2013-11-20 22:01:36 UTC) #12
Xianzhu
7 years, 1 month ago (2013-11-21 01:05:13 UTC) #13
Message was sent while issue was closed. 
Committed patchset #6 manually as r236362 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698