Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 653423003: Support style invalidation for scrollbar pseudo elements. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 2 months ago
Reviewers:
chrishtr, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git/+/master
Project:
blink
Visibility:
Public.

Description

Support style invalidation for scrollbar pseudo elements. No need to fall back to subtree recalc for: ::-webkit-scrollbar ::-webkit-scrollbar-button ::-webkit-scrollbar-thumb ::-webkit-scrollbar-track ::-webkit-scrollbar-track-piece R=chrishtr@chromium.org,esprehn@chromium.org BUG=424546 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -6 lines) Patch
A LayoutTests/fast/css/invalidation/scrollbar-pseudo.html View 1 chunk +113 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/invalidation/scrollbar-pseudo-expected.txt View 1 chunk +45 lines, -0 lines 0 comments Download
M Source/core/css/RuleFeature.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rune
6 years, 2 months ago (2014-10-17 12:30:27 UTC) #1
chrishtr
lgtm
6 years, 2 months ago (2014-10-17 19:37:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653423003/1
6 years, 2 months ago (2014-10-17 19:37:48 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 20:43:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183922

Powered by Google App Engine
This is Rietveld 408576698