Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: public/web/WebFrame.h

Issue 653383002: Add new API for only moving the selection extent point. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/tests/data/move_selection_extent.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 436 matching lines...) Expand 10 before | Expand all | Expand 10 after
447 // Expands the selection to a word around the caret and returns 447 // Expands the selection to a word around the caret and returns
448 // true. Does nothing and returns false if there is no caret or 448 // true. Does nothing and returns false if there is no caret or
449 // there is ranged selection. 449 // there is ranged selection.
450 virtual bool selectWordAroundCaret() = 0; 450 virtual bool selectWordAroundCaret() = 0;
451 451
452 // DEPRECATED: Use moveRangeSelection. 452 // DEPRECATED: Use moveRangeSelection.
453 virtual void selectRange(const WebPoint& base, const WebPoint& extent) = 0; 453 virtual void selectRange(const WebPoint& base, const WebPoint& extent) = 0;
454 454
455 virtual void selectRange(const WebRange&) = 0; 455 virtual void selectRange(const WebRange&) = 0;
456 456
457 // Move the selection extent point.
458 virtual void moveSelectionExtent(const WebPoint&) = 0;
mlamouri (slow - plz ping) 2014/10/15 12:13:51 Can't you define that in public/web/WebLocalFrame.
jdduke (slow) 2014/10/15 17:49:47 I think it would be a little odd to restrict this
christiank 2014/10/17 14:30:24 Sure, I'll move it to WebLocalFrame and rename it
459
457 // Move the current selection to the provided window point/points. If the 460 // Move the current selection to the provided window point/points. If the
458 // current selection is editable, the new selection will be restricted to 461 // current selection is editable, the new selection will be restricted to
459 // the root editable element. 462 // the root editable element.
460 virtual void moveRangeSelection(const WebPoint& base, const WebPoint& extent ) = 0; 463 virtual void moveRangeSelection(const WebPoint& base, const WebPoint& extent ) = 0;
461 virtual void moveCaretSelection(const WebPoint&) = 0; 464 virtual void moveCaretSelection(const WebPoint&) = 0;
462 465
463 virtual bool setEditableSelectionOffsets(int start, int end) = 0; 466 virtual bool setEditableSelectionOffsets(int start, int end) = 0;
464 virtual bool setCompositionFromExistingText(int compositionStart, int compos itionEnd, const WebVector<WebCompositionUnderline>& underlines) = 0; 467 virtual bool setCompositionFromExistingText(int compositionStart, int compos itionEnd, const WebVector<WebCompositionUnderline>& underlines) = 0;
465 virtual void extendSelectionAndDelete(int before, int after) = 0; 468 virtual void extendSelectionAndDelete(int before, int after) = 0;
466 469
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
687 WebPrivateOwnPtr<OpenedFrameTracker> m_openedFrameTracker; 690 WebPrivateOwnPtr<OpenedFrameTracker> m_openedFrameTracker;
688 }; 691 };
689 692
690 #if BLINK_IMPLEMENTATION 693 #if BLINK_IMPLEMENTATION
691 Frame* toCoreFrame(const WebFrame*); 694 Frame* toCoreFrame(const WebFrame*);
692 #endif 695 #endif
693 696
694 } // namespace blink 697 } // namespace blink
695 698
696 #endif 699 #endif
OLDNEW
« no previous file with comments | « Source/web/tests/data/move_selection_extent.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698