Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: tools/idl_parser/test_parser/struct_ppapi.idl

Issue 653343002: Support Promise<T> syntax in the IDL parser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/idl_parser/test_parser/interface_web.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/idl_parser/test_parser/struct_ppapi.idl
diff --git a/tools/idl_parser/test_parser/struct_ppapi.idl b/tools/idl_parser/test_parser/struct_ppapi.idl
index dd017ac47f2e9def0dddae09063ca2ac1eab278a..59bc7eb8648698d261045711239edd4c76a4ddc7 100644
--- a/tools/idl_parser/test_parser/struct_ppapi.idl
+++ b/tools/idl_parser/test_parser/struct_ppapi.idl
@@ -42,6 +42,9 @@ symatics should exist. This is an exact match.
* ExtAttribute(fake_attribute)
* Type()
* PrimitiveType(str_t)
+ * Member(z)
+ * Type()
+ * Typeref(Promise)
* ExtAttributes()
* ExtAttribute(union)
*/
@@ -49,4 +52,5 @@ symatics should exist. This is an exact match.
uint32_t x;
uint64_t y;
[fake_attribute] str_t string;
+ Promise z;
noelallen1 2014/10/16 17:03:05 Didn't you remove Promise from PPAPI parser/lexer?
Jens Widell 2014/10/16 17:08:38 Since it's not a keyword it's just another identif
noelallen1 2014/10/16 18:14:02 We should expect a type here. def p_StructMember(
Jens Widell 2014/10/16 18:21:42 But Type references NotAnyType (indirectly) which
noelallen1 2014/10/16 18:36:25 You are correct. Okay, I agree this is legal un
};
« no previous file with comments | « tools/idl_parser/test_parser/interface_web.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698