Support Promise<T> syntax in the IDL parser.

tools/idl_parser/idl_parser.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """ Parser for PPAPI IDL """
 
 #
 # IDL Parser
 #
@@ skipping 711 matching lines @@
   def p_UnionMemberTypes(self, p):
     """UnionMemberTypes : OR UnionMemberType UnionMemberTypes
                         |"""
 
   # [77] Moved BYTESTRING, DOMSTRING, OBJECT, DATE, REGEXP to PrimitiveType
   # Moving all built-in types into PrimitiveType makes it easier to
   # differentiate between them and 'identifier', since p[1] would be a string in
   # both cases.
   def p_NonAnyType(self, p):
     """NonAnyType : PrimitiveType TypeSuffix
+                  | PromiseType Null
                   | identifier TypeSuffix
                   | SEQUENCE '<' Type '>' Null"""
     if len(p) == 3:
       if type(p[1]) == str:
         typeref = self.BuildNamed('Typeref', p, 1)
       else:
         typeref = p[1]
       p[0] = ListFromConcat(typeref, p[2])
 
     if len(p) == 6:
@@ skipping 152 matching lines @@
 
   # [95]
   def p_ExtendedAttributeNamedArgList(self, p):
     """ExtendedAttributeNamedArgList : identifier '=' identifier '(' ArgumentList ')'"""
     args = self.BuildProduction('Arguments', p, 4, p[5])
     value = self.BuildNamed('Call', p, 3, args)
     p[0] = self.BuildNamed('ExtAttribute', p, 1, value)
 
   # [96] NOT IMPLEMENTED (ExtendedAttributeTypePair)
 
+  # [97]

[Jens Widell, 2014/10/15 07:22:17]

Supposed to be [87]. Looks like a lot of these production numbers are wrong now,
though. Renumber and reorder?

Keeping the numbers synced could be a good idea since it (often) gives you a
rather quick way to check if and where we're missing some update in the spec.

Also, extensions/non-compliances are typically summarized in this comment rather
than (just) in the implementation. So make it "[87] Add unqualified 'Promise'"
or something such?

[noelallen1, 2014/10/15 18:12:32]

Agreed to both.  If you change to a different version of the spec, then please
update the numbers and change the link above so we can have a consistent
reference.  Also, a comment above helps us find this:
# [87] Add unqualified Promise

Next time someone updates the spec, having these notes helps us verify the
feature is still an exception or perhaps it has made it into the spec in a
slightly different form.

[yhirano, 2014/10/16 05:25:47]

Done. I removed numbers from idl_ppapi_parser.py, because they seem useless.

+  def p_PromiseType(self, p):
+    """PromiseType : PROMISE '<' ReturnType '>'
+                   | PROMISE"""
+    if len(p) == 2:
+      # Promise without resolution type is not specified in the Web IDL spec.
+      # As it is used in some specs and in the blink implementation,
+      # we allow that here.
+      type = self.BuildAttribute('ResolutionType',
+                                 self.BuildProduction('Any', p, 1))
+    else:
+      type = self.BuildAttribute('ResolutionType', p[3])
+    p[0] = self.BuildNamed('Promise', p, 1, type)
+
 #
 # Parser Errors
 #
 # p_error is called whenever the parser can not find a pattern match for
 # a set of items from the current state.  The p_error function defined here
 # is triggered logging an error, and parsing recovery happens as the
 # p_<type>_error functions defined above are called.  This allows the parser
 # to continue so as to capture more than one error per file.
 #
   def p_error(self, t):
@@ skipping 199 matching lines @@
 
   print '\n'.join(ast.Tree(accept_props=['PROD']))
   if errors:
     print '\nFound %d errors.\n' % errors
 
   return errors
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))