components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h - Issue 653313003: Check effective proxy config before adding data reduction proxies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h

Issue 653313003: Check effective proxy config before adding data reduction proxies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/net/chrome_network_delegate.h ('K') | « chrome/browser/net/chrome_network_delegate.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.cc » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h

index ac42fc70baf81c9de33a9351b5bb277016f676f0..54abc023a73c22c4f61e509991c6d3a161d25cb7 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_protocol.h

@@ -44,9 +44,12 @@ bool MaybeBypassProxyAndPrepareToRetry(

// DataCompressionProxyCriticalBypass Finch trial is set.

// This handler is intended to be invoked only by

// |ChromeNetworkDelegate.NotifyResolveProxy|.

+// Also, apply the data reduction proxy configuration if another configuration

mef 2014/10/30 21:05:36 The comment overall seems a bit stale. Could you i

bengr 2014/11/03 23:26:58 Done.

+// is in use and it resolves to direct.

void OnResolveProxyHandler(const GURL& url,

int load_flags,

const net::ProxyConfig& data_reduction_proxy_config,

+ const net::ProxyConfig& proxy_service_proxy_config,

const net::ProxyRetryInfoMap& proxy_retry_info,

const DataReductionProxyParams* params,

net::ProxyInfo* result);