Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2521)

Unified Diff: chrome/browser/net/chrome_network_delegate.cc

Issue 653313003: Check effective proxy config before adding data reduction proxies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/chrome_network_delegate.cc
diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc
index d295cc0620b0a4fc54ec3eb7e6f81613c6471937..1954b36cad472e7dafa7544260df5e5601335598 100644
--- a/chrome/browser/net/chrome_network_delegate.cc
+++ b/chrome/browser/net/chrome_network_delegate.cc
@@ -442,8 +442,10 @@ void ChromeNetworkDelegate::OnResolveProxy(
!proxy_config_getter_.is_null()) {
on_resolve_proxy_handler_.Run(url, load_flags,
proxy_config_getter_.Run(),
+ proxy_service.config(),
marq (ping after 24h) 2014/10/28 08:15:27 This change will also need to be made in CrNet's n
bengr 2014/10/29 21:12:36 Acknowledged.
proxy_service.proxy_retry_info(),
- data_reduction_proxy_params_, result);
+ data_reduction_proxy_params_,
+ result);
marq (ping after 24h) 2014/10/28 08:15:27 No need to move this onto another line, as method
bengr 2014/10/29 21:12:36 Done.
}
}

Powered by Google App Engine
This is Rietveld 408576698