Issue 6533: * Added simplified Boyer-Moore-Horspool text search.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6533: * Added simplified Boyer-Moore-Horspool text search. (Closed)

Created:
12 years, 2 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

KMP algorithm is still left in the source. If this change checks out to be faster, it should be removed.

Patch Set 1 #

Patch Set 2 : Included comments from review #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -20 lines)			Patch
M	src/jsregexp.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	1	4 chunks	+80 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

12 years, 2 months ago (2008-10-07 12:32:40 UTC) #2

LGTM

http://codereview.chromium.org/6533/diff/1/3
File src/runtime.cc (right):

http://codereview.chromium.org/6533/diff/1/3#newcode1036
Line 1036: // Significant bits taken from that character to use in bad-character
'that' seems to be a dangling reference

http://codereview.chromium.org/6533/diff/1/3#newcode1056
Line 1056: SmartPointer<byte> bad_char_map(NewArray<byte>(kBMHBadCharCount));
May as well be static for speed!

http://codereview.chromium.org/6533/diff/1/3#newcode1062
Line 1062: for(int i = p < m ? m - p : 0; i < m - 1; i++) {
Single-character variable overload here!

http://codereview.chromium.org/6533/diff/1/3#newcode1063
Line 1063: pchar c = pattern[i];
if (sizeof(schar) == 1 && c > 255) return -1;

http://codereview.chromium.org/6533/diff/1/3#newcode1147
Line 1147: // For small searches, KMP is not worth the setup overhead.
KMP?

Expand Messages | Collapse Messages