Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 653283005: Implement style recalc invalidation tracking in devtools (Closed)

Created:
6 years, 2 months ago by pdr.
Modified:
6 years, 2 months ago
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Implement style recalc invalidation tracking in devtools This patch adds style recalc invalidation tracking to the invalidation tracking experiment. Our full design doc is at: https://docs.google.com/document/d/1BXT3_gD--YdbIYMlTzNGsyUUMBCZJ7V5qGJhMA-pGrs/edit This patch implements the invalidation tracking logic for style recalc events. All style invalidations are recorded and when a style recalc occurs they are collected and displayed to the user. Additional style invalidation information (e.g., detailed reasons) will be added in a followup. The existing invalidation tests have been renamed because they are only for paint events. A new test has been added for style recalc events. BUG=410701 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184212

Patch Set 1 #

Patch Set 2 : Fix minor typeo: _addInvalidationTrackingEvent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -343 lines) Patch
D LayoutTests/inspector/tracing/timeline-layout-deleted-node-invalidations.html View 1 chunk +0 lines, -101 lines 0 comments Download
D LayoutTests/inspector/tracing/timeline-layout-deleted-node-invalidations-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/inspector/tracing/timeline-layout-invalidations.html View 1 chunk +0 lines, -94 lines 0 comments Download
D LayoutTests/inspector/tracing/timeline-layout-invalidations-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-paint-with-layout-invalidations.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/inspector/tracing/timeline-paint-with-layout-invalidations-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-paint-with-layout-invalidations-on-deleted-node.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-paint-with-layout-invalidations-on-deleted-node-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-paint-with-style-recalc-invalidations.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/inspector/tracing/timeline-paint-with-style-recalc-invalidations-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
D LayoutTests/inspector/tracing/timeline-style-recalc-invalidations.html View 1 chunk +0 lines, -87 lines 0 comments Download
D LayoutTests/inspector/tracing/timeline-style-recalc-invalidations-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
A + LayoutTests/inspector/tracing/timeline-style-recalc-with-invalidations.html View 4 chunks +21 lines, -29 lines 0 comments Download
A LayoutTests/inspector/tracing/timeline-style-recalc-with-invalidations-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 1 4 chunks +36 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pdr.
PTAL. I expected this to be more difficult but it appears to be pretty simple. ...
6 years, 2 months ago (2014-10-22 04:32:38 UTC) #2
kouhei (in TOK)
Event join logic lgtm. caseq, yurys: Would you take a look?
6 years, 2 months ago (2014-10-22 05:06:28 UTC) #3
yurys
lgtm
6 years, 2 months ago (2014-10-22 05:55:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653283005/20001
6 years, 2 months ago (2014-10-22 17:16:04 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 19:14:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184212

Powered by Google App Engine
This is Rietveld 408576698