Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 653283004: ServiceWorker: Reset message in serviceworker-internals with update (Closed)

Created:
6 years, 2 months ago by shimazu
Modified:
6 years, 2 months ago
Reviewers:
horo
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Reset message in serviceworker-internals with update Currently, when there are two registration and above one is unregistered, console message by above registration is left in top console box though the bottom one goes to the top. Then, the message in each box is set to the message recorded internally when update() is called. BUG=418568 TEST=N/A Committed: https://crrev.com/6610f2bad81f726931ca8d664f2ac8c0e323115a Cr-Commit-Position: refs/heads/master@{#300027}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add +2 indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M content/browser/resources/service_worker/serviceworker_internals.js View 1 4 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
shimazu
PTAL
6 years, 2 months ago (2014-10-15 08:32:17 UTC) #2
horo
lgtm wit nits Thank you! https://codereview.chromium.org/653283004/diff/1/content/browser/resources/service_worker/serviceworker_internals.js File content/browser/resources/service_worker/serviceworker_internals.js (right): https://codereview.chromium.org/653283004/diff/1/content/browser/resources/service_worker/serviceworker_internals.js#newcode96 content/browser/resources/service_worker/serviceworker_internals.js:96: logArea.version_id == version.version_id) { ...
6 years, 2 months ago (2014-10-16 03:39:35 UTC) #3
shimazu
https://codereview.chromium.org/653283004/diff/1/content/browser/resources/service_worker/serviceworker_internals.js File content/browser/resources/service_worker/serviceworker_internals.js (right): https://codereview.chromium.org/653283004/diff/1/content/browser/resources/service_worker/serviceworker_internals.js#newcode96 content/browser/resources/service_worker/serviceworker_internals.js:96: logArea.version_id == version.version_id) { On 2014/10/16 03:39:35, horo wrote: ...
6 years, 2 months ago (2014-10-16 07:42:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653283004/20001
6 years, 2 months ago (2014-10-16 07:43:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/64049)
6 years, 2 months ago (2014-10-16 08:50:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653283004/20001
6 years, 2 months ago (2014-10-17 00:37:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-17 00:38:24 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 00:39:36 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6610f2bad81f726931ca8d664f2ac8c0e323115a
Cr-Commit-Position: refs/heads/master@{#300027}

Powered by Google App Engine
This is Rietveld 408576698