Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 653263006: Remove redundant [WillBeGarbageCollected] uses on derived EventTargets. (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 2 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, shans, tzik, eae+blinkwatch, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, kinuko+worker_chromium.org, Steve Block, rwlbuis, jsbell+serviceworker_chromium.org, Yoav Weiss, arv+blink, blink-reviews-dom_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, Timothy Loh, dstockwell, dglazkov+blink, blink-reviews-events_chromium.org, gavinp+loader_chromium.org, rune+blink, Eric Willigers, kenneth.christiansen, nessy, rjwright, sof, nhiroki, darktears, Nate Chapin, vcarbune.chromium, philipj_slow, michaeln, blink-reviews-animation_chromium.org, serviceworker-reviews, gasubic, falken, Mike Lawther (Google), ed+blinkwatch_opera.com, kinuko+serviceworker, Inactive, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove redundant [WillBeGarbageCollected] uses on derived EventTargets. [WillBeGarbageCollected] is already inherited from the parent EventTarget. R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M Source/core/animation/AnimationPlayer.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/MediaQueryList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/MessagePort.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/TextTrack.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/TextTrackCue.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/appcache/ApplicationCache.idl View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/page/EventSource.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/timing/Performance.idl View 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/workers/SharedWorker.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/Worker.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look. Just some minor tidying.
6 years, 2 months ago (2014-10-16 08:37:32 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-16 08:39:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653263006/1
6 years, 2 months ago (2014-10-16 09:28:40 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 10:29:06 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183800

Powered by Google App Engine
This is Rietveld 408576698