DevTools: CSSAgent::enable should report an error if DOM agent hasn't been enabled

DevTools: CSSAgent::enable should report an error if DOM agent hasn't been enabled

BUG=423686
R= yurys@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183752

[loislo, 2014-10-15 09:15:31]

ptal

[yurys, 2014-10-15 09:29:11]

https://codereview.chromium.org/653263004/diff/1/Source/core/inspector/Inspec...
File Source/core/inspector/InspectorCSSAgent.cpp (right):

https://codereview.chromium.org/653263004/diff/1/Source/core/inspector/Inspec...
Source/core/inspector/InspectorCSSAgent.cpp:459: *errorString = "DOM agent needs
to be enabled first.";
Why is that? Can you provide a test case? Should we automatically enable DOM
agent?

[vsevik, 2014-10-15 09:34:37]

And what about other agents that css agent depends on?
and other agents that depend on other agents?

[loislo, 2014-10-15 13:34:08]

On 2014/10/15 09:34:37, vsevik wrote:
> And what about other agents that css agent depends on?
> and other agents that depend on other agents?

comments addressed. ptal.

[vsevik, 2014-10-15 13:47:19]

vsevik@chromium.org changed reviewers:
+ vsevik@chromium.org

[vsevik, 2014-10-15 13:47:19]

The CQ bit was checked by vsevik@chromium.org

[vsevik, 2014-10-15 13:47:20]

lgtm

[commit-bot: I haz the power, 2014-10-15 13:48:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/653263004/20001

[yurys, 2014-10-15 14:12:38]

lgtm

https://codereview.chromium.org/653263004/diff/20001/LayoutTests/inspector/ag...
File LayoutTests/inspector/agents-enable-disable.html (right):

https://codereview.chromium.org/653263004/diff/20001/LayoutTests/inspector/ag...
LayoutTests/inspector/agents-enable-disable.html:28:
targets.forEach(function(target) {
style: { should go on the next line. Here and below.

[commit-bot: I haz the power, 2014-10-15 14:51:30]

Committed patchset #2 (id:20001) as 183752