Fix GetCurrentThreadId for Solaris etc..

Fix GetCurrentThreadId for Solaris etc..

BUG=v8:3620
R=svenpanne@chromium.org
LOG=n

Committed: https://code.google.com/p/v8/source/detail?r=24634

[Sven Panne, 2014-10-15 08:54:52]

LGTM (almost :-} )

https://codereview.chromium.org/653263003/diff/1/src/base/platform/platform-p...
File src/base/platform/platform-posix.cc (right):

https://codereview.chromium.org/653263003/diff/1/src/base/platform/platform-p...
src/base/platform/platform-posix.cc:263: return
static_cast<int>(pthread_self());
Hmmm, this is still a bit wacky and will fail some day: pthread_t is an opaque
type, and apart from passing it around and comparing it for equality (via
pthread_equal) there's not much you can do portably.

This needs to be fixed for real at some point, but let's see what breaks for
now... :-/

[jochen (gone - plz use gerrit), 2014-10-15 12:39:02]

Committed patchset #1 (id:1) manually as 24634 (presubmit successful).

[Sven Panne, 2014-10-27 07:34:58]

On 2014/10/15 08:54:52, Sven Panne wrote:
> [...] This needs to be fixed for real at some point, but let's see what breaks
for
> now... :-/

Fun fact: This is one of the reasons our NaCL builds fail:
http://chromegw.corp.google.com/i/client.v8/builders/NaCl%20V8%20Linux64%20-%...

[Robert Nagy, 2014-12-07 13:04:12]

On 2014/10/27 07:34:58, Sven Panne wrote:
> On 2014/10/15 08:54:52, Sven Panne wrote:
> > [...] This needs to be fixed for real at some point, but let's see what
breaks
> for
> > now... :-/
> 
> Fun fact: This is one of the reasons our NaCL builds fail:
>
http://chromegw.corp.google.com/i/client.v8/builders/NaCl%20V8%20Linux64%20-%...


OpenBSD breaks with this change.

../../v8/src/base/platform/platform-posix.cc:263:10: error: static_cast from
'pthread_t' (aka 'pthread *') to 'int' is not allowed
  return static_cast<int>(pthread_self());
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~