Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: Source/core/css/CSSStyleSheet.cpp

Issue 653223002: Navigation transitions (web to native app): Revert exit transition (Blink side) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add tests Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSStyleSheet.cpp
diff --git a/Source/core/css/CSSStyleSheet.cpp b/Source/core/css/CSSStyleSheet.cpp
index 705d3283da8707459b4002a670ea53176e068975..ec71fd782dceaeca784ba7d1d4f1c2b591212062 100644
--- a/Source/core/css/CSSStyleSheet.cpp
+++ b/Source/core/css/CSSStyleSheet.cpp
@@ -37,6 +37,7 @@
#include "core/dom/ExceptionCode.h"
#include "core/dom/Node.h"
#include "core/frame/UseCounter.h"
+#include "core/html/HTMLLinkElement.h"
#include "core/html/HTMLStyleElement.h"
#include "core/inspector/InspectorInstrumentation.h"
#include "core/svg/SVGStyleElement.h"
@@ -223,7 +224,17 @@ void CSSStyleSheet::setDisabled(bool disabled)
return;
m_isDisabled = disabled;
- didMutate();
+ bool isTransitionExitingStylesheet = false;
+ if (isHTMLLinkElement(*m_ownerNode)) {
+ HTMLLinkElement& linkElement = toHTMLLinkElement(*m_ownerNode);
+ isTransitionExitingStylesheet =
+ linkElement.relAttribute().isTransitionExitingStylesheet();
+ }
+
+ if (isTransitionExitingStylesheet)
+ didMutate(EntireStyleSheetUpdate);
esprehn 2014/10/15 18:01:26 Transition sheets shouldn't be special, CSSStyleSh
Zhen Wang 2014/10/15 19:50:58 The default will lead to FullStyleUpdate. We need
esprehn 2014/10/15 20:19:07 This is not correct, I don't know what you're talk
Zhen Wang 2014/10/15 23:04:41 I agree that this is a strange behavior. I am not
Zhen Wang 2014/12/03 17:54:29 This is fixed by resetIsTransitionDocument now.
+ else
+ didMutate();
}
void CSSStyleSheet::setMediaQueries(PassRefPtrWillBeRawPtr<MediaQuerySet> mediaQueries)

Powered by Google App Engine
This is Rietveld 408576698