Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 653213002: Implement MediaSource support for mojo. (Closed)

Created:
6 years, 2 months ago by DaleCurtis
Modified:
6 years, 2 months ago
Reviewers:
jamesr, xhwang
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Implement MediaSource support for mojo. - Implements WebMimeRegistryImpl::supportsMediaSourceMIMEType(). - Changes NullEncryptedMediaPlayerSupport to return a callback bound to NOTIMPLEMENTED() for the NeedKeyCB. BUG=423416 TEST=basic mse player plays! Committed: https://crrev.com/328d4822fc471b4fa3c137656758db752bbb749d Cr-Commit-Position: refs/heads/master@{#300012}

Patch Set 1 : Implement! #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M media/blink/null_encrypted_media_player_support.cc View 2 chunks +7 lines, -1 line 2 comments Download
M mojo/services/html_viewer/webmimeregistry_impl.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
DaleCurtis
isTypeSupported() implementation stolen from https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/renderer_blink_platform_impl.cc&l=435
6 years, 2 months ago (2014-10-14 21:32:32 UTC) #3
xhwang
Great! LGTM
6 years, 2 months ago (2014-10-15 03:52:35 UTC) #4
DaleCurtis
jamesr: ping?
6 years, 2 months ago (2014-10-16 18:21:12 UTC) #5
jamesr
mojo/ lgtm https://codereview.chromium.org/653213002/diff/20001/media/blink/null_encrypted_media_player_support.cc File media/blink/null_encrypted_media_player_support.cc (right): https://codereview.chromium.org/653213002/diff/20001/media/blink/null_encrypted_media_player_support.cc#newcode13 media/blink/null_encrypted_media_player_support.cc:13: static void NeedKeyHandler(const std::string& type, i think ...
6 years, 2 months ago (2014-10-16 18:24:01 UTC) #6
DaleCurtis
Thanks for review! https://codereview.chromium.org/653213002/diff/20001/media/blink/null_encrypted_media_player_support.cc File media/blink/null_encrypted_media_player_support.cc (right): https://codereview.chromium.org/653213002/diff/20001/media/blink/null_encrypted_media_player_support.cc#newcode13 media/blink/null_encrypted_media_player_support.cc:13: static void NeedKeyHandler(const std::string& type, On ...
6 years, 2 months ago (2014-10-16 18:29:50 UTC) #7
xhwang
On 2014/10/16 18:29:50, DaleCurtis wrote: > Thanks for review! > > https://codereview.chromium.org/653213002/diff/20001/media/blink/null_encrypted_media_player_support.cc > File media/blink/null_encrypted_media_player_support.cc ...
6 years, 2 months ago (2014-10-16 21:24:51 UTC) #8
DaleCurtis
Thanks for review everyone!
6 years, 2 months ago (2014-10-16 21:26:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653213002/20001
6 years, 2 months ago (2014-10-16 21:27:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 2 months ago (2014-10-16 23:43:52 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 23:44:29 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/328d4822fc471b4fa3c137656758db752bbb749d
Cr-Commit-Position: refs/heads/master@{#300012}

Powered by Google App Engine
This is Rietveld 408576698