Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 653203005: Roll WebRTC 7546:7549. (Closed)

Created:
6 years, 2 months ago by hellner1
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-ipc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll WebRTC 7546:7549. TBR=hellner@chromium.org NOTRY=true BUG=N/A Committed: https://crrev.com/4e40bbe50a102784984852ca318dbcd2b03fc9fc Cr-Commit-Position: refs/heads/master@{#301879} Committed: https://crrev.com/ecb39f13449e606ca66b6d3401c3f306c65c2859 Cr-Commit-Position: refs/heads/master@{#302260}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : brought libjingle_p2p_constants_nacl back #

Patch Set 4 : DEPS change disappeared, this brings it back #

Patch Set 5 : change libjingle target type #

Patch Set 6 : rebase #

Patch Set 7 : fixes gn build #

Patch Set 8 : Rebase to roll r7546-7549 #

Patch Set 9 : Decreased the number of gyp changes in this patch since thats the only major change (the reset is j… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -315 lines) Patch
M DEPS View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M components/invalidation/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/invalidation_notifier.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/ipc_socket_factory.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/port_allocator.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/channel_socket_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/channel_socket_adapter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/chrome_async_socket.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/pseudotcp_adapter.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/fake_base_task.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/gaia_token_pre_xmpp_auth.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/gaia_token_pre_xmpp_auth.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/base/notifier_options_util.h View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/notifier_options_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/base/weak_xmpp_client.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/xmpp_connection.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/xmpp_connection.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/xmpp_connection_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/communicator/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/communicator/connection_settings.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M jingle/notifier/communicator/login.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/communicator/login.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M jingle/notifier/communicator/login_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/communicator/login_settings_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/communicator/single_login_attempt.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/communicator/single_login_attempt.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt_unittest.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/listener/push_notifications_listen_task.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/push_notifications_listen_task.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/notifier/listener/push_notifications_send_update_task.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/push_notifications_send_update_task.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/notifier/listener/push_notifications_send_update_task_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/push_notifications_subscribe_task.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/push_notifications_subscribe_task.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/notifier/listener/push_notifications_subscribe_task_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/send_ping_task.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/send_ping_task.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/notifier/listener/send_ping_task_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/xmpp_push_client.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M remoting/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/client/plugin/pepper_packet_socket_factory.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/pepper_port_allocator.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/heartbeat_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/heartbeat_sender_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_change_notification_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_change_notification_listener_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/host_status_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/register_support_host_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/register_support_host_request_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/chromium_port_allocator.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/chromium_socket_factory.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/content_description.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/jingle_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_messages_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/libjingle_transport_factory.cc View 1 2 3 4 5 6 7 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/signaling/fake_signal_strategy.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/signaling/iq_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/signaling/iq_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/signaling/jingle_info_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/signaling/log_to_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/signaling/xmpp_signal_strategy.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M remoting/signaling/xmpp_signal_strategy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/test/fake_network_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/test/fake_port_allocator.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M remoting/test/fake_socket_factory.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/BUILD.gn View 1 2 3 4 5 6 7 2 chunks +119 lines, -115 lines 0 comments Download
M third_party/libjingle/README.chromium View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/libjingle.gyp View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -4 lines 0 comments Download
D third_party/libjingle/libjingle_common.gypi View 1 2 3 4 5 6 7 8 1 chunk +99 lines, -97 lines 0 comments Download
M third_party/libjingle/libjingle_nacl.gyp View 1 2 3 4 5 6 7 8 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 34 (9 generated)
hellner1
PTAL Synopsis: libjingle is moving into webrtc. This cl rolls chromium DEPS picking up latest ...
6 years, 2 months ago (2014-10-15 22:41:28 UTC) #2
dcheng
components/invalidation LGTM
6 years, 2 months ago (2014-10-15 23:04:34 UTC) #3
Jamie
https://codereview.chromium.org/653203005/diff/1/remoting/remoting_nacl.gyp File remoting/remoting_nacl.gyp (left): https://codereview.chromium.org/653203005/diff/1/remoting/remoting_nacl.gyp#oldcode158 remoting/remoting_nacl.gyp:158: '>(tc_lib_dir_pnacl_newlib)/libjingle_p2p_constants_nacl.a', I'm surprised to see this deleted rather than ...
6 years, 2 months ago (2014-10-16 00:31:39 UTC) #5
hellner1
https://codereview.chromium.org/653203005/diff/1/remoting/remoting_nacl.gyp File remoting/remoting_nacl.gyp (left): https://codereview.chromium.org/653203005/diff/1/remoting/remoting_nacl.gyp#oldcode158 remoting/remoting_nacl.gyp:158: '>(tc_lib_dir_pnacl_newlib)/libjingle_p2p_constants_nacl.a', On 2014/10/16 00:31:39, Jamie wrote: > I'm surprised ...
6 years, 2 months ago (2014-10-16 14:45:50 UTC) #6
hellner1
PTAL Seems Sergey is on paternity leave. content/browser/renderer_host/p2p hclam jingle - hclam third_party/libjingle - hclam ...
6 years, 2 months ago (2014-10-16 22:31:12 UTC) #8
hellner1
Forgot to add hclam. PTAL
6 years, 2 months ago (2014-10-16 22:37:33 UTC) #10
Alpha Left Google
lgtm
6 years, 2 months ago (2014-10-16 22:38:06 UTC) #12
Peter Kasting
hellner, are you going to land this at some point? Or has this been superseded?
6 years, 2 months ago (2014-10-21 20:44:50 UTC) #14
hellner1
On 2014/10/21 20:44:50, Peter Kasting wrote: > hellner, are you going to land this at ...
6 years, 2 months ago (2014-10-22 14:28:51 UTC) #15
hellner1
On 2014/10/22 14:28:51, hellner1 wrote: > On 2014/10/21 20:44:50, Peter Kasting wrote: > > hellner, ...
6 years, 1 month ago (2014-10-27 21:25:20 UTC) #16
jamesr
On 2014/10/27 21:25:20, hellner1 wrote: > On 2014/10/22 14:28:51, hellner1 wrote: > > On 2014/10/21 ...
6 years, 1 month ago (2014-10-27 21:26:11 UTC) #17
hellner1
On 2014/10/27 21:26:11, jamesr wrote: > On 2014/10/27 21:25:20, hellner1 wrote: > > On 2014/10/22 ...
6 years, 1 month ago (2014-10-27 21:31:29 UTC) #18
jamesr
On 2014/10/27 21:31:29, hellner1 wrote: > On 2014/10/27 21:26:11, jamesr wrote: > > Sorry, what ...
6 years, 1 month ago (2014-10-27 21:32:15 UTC) #19
hellner1
On 2014/10/27 21:32:15, jamesr wrote: > On 2014/10/27 21:31:29, hellner1 wrote: > > On 2014/10/27 ...
6 years, 1 month ago (2014-10-27 21:34:18 UTC) #20
Jamie
remoting/ lgtm
6 years, 1 month ago (2014-10-28 00:28:23 UTC) #21
jamesr
content/renderer/ lgtm
6 years, 1 month ago (2014-10-28 00:29:26 UTC) #22
henrike
LGTM (to fix presubmit warnings for DEPS changes)
6 years, 1 month ago (2014-10-29 16:12:15 UTC) #24
hellner1
tbr-ed myself to get past check deps since I am an owner of the target ...
6 years, 1 month ago (2014-10-29 17:57:31 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653203005/140001
6 years, 1 month ago (2014-10-29 18:21:02 UTC) #27
commit-bot: I haz the power
Committed patchset #8 (id:140001)
6 years, 1 month ago (2014-10-29 18:23:30 UTC) #28
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/4e40bbe50a102784984852ca318dbcd2b03fc9fc Cr-Commit-Position: refs/heads/master@{#301879}
6 years, 1 month ago (2014-10-29 18:24:12 UTC) #29
Mike Wittman
Reverted this in 6ca1a64c4ab2d2e97d529808fd66d7bf63dd8b66. Appears to cause timeouts on Mac 10.6 and 10.7 tests: JingleSessionTest.TestFailedChannelAuth ...
6 years, 1 month ago (2014-10-29 19:52:35 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653203005/160001
6 years, 1 month ago (2014-10-31 14:21:36 UTC) #32
commit-bot: I haz the power
Committed patchset #9 (id:160001)
6 years, 1 month ago (2014-10-31 14:23:15 UTC) #33
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 14:24:03 UTC) #34
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/ecb39f13449e606ca66b6d3401c3f306c65c2859
Cr-Commit-Position: refs/heads/master@{#302260}

Powered by Google App Engine
This is Rietveld 408576698