Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 653183006: SkLazyPtr suitable as a local or class member. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkLazyPtr suitable as a local or class member. BUG=skia: Committed: https://skia.googlesource.com/skia/+/1d932663e12dc5f56a66bb764c9f36eb3bab9502

Patch Set 1 #

Patch Set 2 : threaded test #

Patch Set 3 : simplify / contend more #

Patch Set 4 : tweak #

Patch Set 5 : rebase #

Patch Set 6 : dtor #

Patch Set 7 : neverRead #

Patch Set 8 : Base #

Patch Set 9 : namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -5 lines) Patch
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkLazyPtr.h View 1 2 3 4 5 6 7 6 chunks +18 lines, -5 lines 0 comments Download
A tests/LazyPtr.cpp View 1 2 3 4 5 6 7 8 1 chunk +48 lines, -0 lines 0 comments Download
M tests/OnceTest.cpp View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653183006/140001
6 years, 2 months ago (2014-10-20 20:15:23 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-20 20:15:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653183006/160001
6 years, 2 months ago (2014-10-20 20:21:28 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-20 20:21:29 UTC) #6
mtklein
This is what I'd suggest using to implement things like lazy font metrics.
6 years, 2 months ago (2014-10-20 20:24:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/129)
6 years, 2 months ago (2014-10-20 20:27:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653183006/160001
6 years, 2 months ago (2014-10-20 20:30:48 UTC) #12
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-20 20:30:49 UTC) #13
reed1
I have absolutely no idea what is going on. lgtm
6 years, 2 months ago (2014-10-20 20:45:43 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 20:46:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as 1d932663e12dc5f56a66bb764c9f36eb3bab9502

Powered by Google App Engine
This is Rietveld 408576698