Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2362)

Unified Diff: android_webview/browser/browser_view_renderer.cc

Issue 653173004: Part 2: WIP Refactor Webview graphics related code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/browser_view_renderer.cc
diff --git a/android_webview/browser/browser_view_renderer.cc b/android_webview/browser/browser_view_renderer.cc
index f897b0ce0642732e3a7549b2d5924830ab153523..771c772b69687977c2c96edac9ea7edaf47ed0a1 100644
--- a/android_webview/browser/browser_view_renderer.cc
+++ b/android_webview/browser/browser_view_renderer.cc
@@ -331,6 +331,10 @@ void BrowserViewRenderer::DidSkipCommitFrame() {
DidSkipCompositeInDraw();
}
+void BrowserViewRenderer::InvalidateOnFunctorDestroy() {
+ client_->InvalidateOnFunctorDestroy();
+}
+
bool BrowserViewRenderer::OnDrawSoftware(jobject java_canvas) {
if (!compositor_) {
TRACE_EVENT_INSTANT0(
@@ -453,11 +457,9 @@ void BrowserViewRenderer::OnDetachedFromWindow() {
void BrowserViewRenderer::ReleaseHardware() {
DCHECK(hardware_enabled_);
- // TODO(hush): do this in somewhere else. Either in hardware render or in
- // shared renderer state.
- ReturnUnusedResource(shared_renderer_state_.PassCompositorFrame());
+ ReturnUnusedResource(shared_renderer_state_.PassUncommittedFrameOnUI());
ReturnResourceFromParent();
- DCHECK(shared_renderer_state_.ReturnedResourcesEmpty());
+ DCHECK(shared_renderer_state_.ReturnedResourcesEmptyOnUI());
if (compositor_) {
compositor_->ReleaseHwDraw();
@@ -754,7 +756,7 @@ void BrowserViewRenderer::FallbackTickFired() {
if (compositor_needs_continuous_invalidate_ && compositor_) {
if (hardware_enabled_) {
ReturnResourceFromParent();
- ReturnUnusedResource(shared_renderer_state_.PassCompositorFrame());
+ ReturnUnusedResource(shared_renderer_state_.PassUncommittedFrameOnUI());
scoped_ptr<cc::CompositorFrame> frame = CompositeHw();
if (frame.get()) {
shared_renderer_state_.SetCompositorFrameOnUI(frame.Pass(), true);
« no previous file with comments | « android_webview/browser/browser_view_renderer.h ('k') | android_webview/browser/browser_view_renderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698