Part 2: WIP Refactor Webview graphics related code

android_webview/native/aw_contents.h

Index: android_webview/native/aw_contents.h
diff --git a/android_webview/native/aw_contents.h b/android_webview/native/aw_contents.h
index 8f42a9202cbeeab097ed3e80a2d4c3be3cfed6a7..6c55eb5685025eb2c4963d1c8cb2d9b8cc69aa28 100644
--- a/android_webview/native/aw_contents.h
+++ b/android_webview/native/aw_contents.h
@@ -191,6 +191,7 @@ class AwContents : public FindHelper::Listener,
   // BrowserViewRendererClient implementation.
   virtual bool RequestDrawGL(bool wait_for_completion) override;
   virtual void PostInvalidate() override;
+  virtual void InvalidateOnFunctorDestroy() override;
   virtual void UpdateParentDrawConstraints() override;
   virtual void DidSkipCommitFrame() override;
   virtual void OnNewPicture() override;
@@ -243,9 +244,6 @@ class AwContents : public FindHelper::Listener,
   // SharedRendererState is owned by BrowserViewRenderer.
   // So keep a raw pointer here.
   SharedRendererState* shared_renderer_state_;

[boliu, 2014/10/28 19:49:43]

At _some_ point in the future, we should be able to remove this pointer as well.

[hush (inactive), 2014/10/29 19:57:04]

Yes, hopefully. Added a TODO here.
I guess one major thing is DrawGL functor registration.
Right now AwContents::DrawGL is registered as the functor. To remove this
pointer, we need to register SharedRendererState::DrawGL instead? So that
AwContents does not need to forward the call to SharedRendererState. But that
breaks the assumption that AwContents being the boundary between java and native
and exposes the existence of SRS to android frameworks somehow.

[boliu, 2014/10/29 22:40:33]

Yeah that's the idea I have in my head.
The other side of functor isn't java though. Also to frameworks, it's just an
opaque pointer, we are not exposing anything.

[hush (inactive), 2014/10/30 00:46:36]

filed https://code.google.com/p/chromium/issues/detail?id=428550 for it.

-  // TODO(hush): hardware renderer will be owned by SharedRendererState,
-  // after DrawGL is moved to SharedRendererState.
-  scoped_ptr<HardwareRenderer> hardware_renderer_;
   scoped_ptr<AwPdfExporter> pdf_exporter_;
   scoped_ptr<PermissionRequestHandler> permission_request_handler_;