Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 653133004: Change drawText() to generate positions and send to drawPosText() (Closed)

Created:
6 years, 2 months ago by jvanverth1
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Change drawText() to generate positions and send to drawPosText() The idea here is to have a central place that does layout for drawText(), and then always feed text through drawPosText(). This both makes all of the GrTextContexts consistent in drawText() output, and does a better job of stressing drawPosText(). Because of the effect of matrices on hinting and approximation error, the generated text is not 100% identical to that produced by the raster pipeline. BUG=skia:2887 Committed: https://skia.googlesource.com/skia/+/7851a56895c9c076f73a835a7dd51d3c6180c16f

Patch Set 1 #

Patch Set 2 : Move drawText out of subcontexts #

Patch Set 3 : Use fixed point math for computing positions #

Patch Set 4 : Add ignored GMs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -279 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M include/core/SkPaint.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrBitmapTextContext.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 1 2 chunks +0 lines, -92 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 2 4 chunks +10 lines, -78 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 1 2 chunks +0 lines, -91 lines 0 comments Download
M src/gpu/GrTextContext.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 1 2 1 chunk +56 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jvanverth1
6 years, 2 months ago (2014-10-15 21:07:34 UTC) #3
reed1
api part lgtm
6 years, 2 months ago (2014-10-15 21:17:57 UTC) #4
bungeman-skia
On 2014/10/15 21:17:57, reed1 wrote: > api part lgtm lgtm
6 years, 2 months ago (2014-10-15 21:18:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653133004/60001
6 years, 2 months ago (2014-10-16 13:13:47 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 7851a56895c9c076f73a835a7dd51d3c6180c16f
6 years, 2 months ago (2014-10-16 13:20:40 UTC) #8
jvanverth1
6 years, 2 months ago (2014-10-16 15:04:06 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/659993003/ by jvanverth@google.com.

The reason for reverting is: A large number of GMs on Ubuntu12 are failing. The
text layout on GPU is visibly different than that for 8888..

Powered by Google App Engine
This is Rietveld 408576698