Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Issue 653133003: [Mac] Add menu to reload button available when debugging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
index 0dd797acccc9715a371e6e0108d7bab92ad5500c..1f7f383f3a7b1aed730d79ce073ac69b6bf10c83 100644
--- a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
@@ -22,6 +22,7 @@
#include "chrome/browser/search/search.h"
#include "chrome/browser/themes/theme_service.h"
#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_window.h"
#import "chrome/browser/ui/cocoa/background_gradient_view.h"
#include "chrome/browser/ui/cocoa/drag_util.h"
@@ -258,6 +259,7 @@ class NotificationBridge : public WrenchMenuBadgeController::Delegate {
[homeButton_ setHandleMiddleClick:YES];
[self initCommandStatus:commands_];
+ [reloadButton_ setCommandUpdater:commands_];
locationBarView_.reset(new LocationBarViewMac(locationBar_, commands_,
profile_, browser_));
@@ -440,6 +442,9 @@ class NotificationBridge : public WrenchMenuBadgeController::Delegate {
if (browserActionsController_.get()) {
[browserActionsController_ update];
}
+
+ BOOL needReloadMenu = chrome::IsDebuggerAttachedToCurrentTab(browser_);
vsevik 2014/10/14 19:53:37 Just to clarify: will this code be executed each t
dgozman 2014/10/15 10:20:56 Yes. It's very similar to views codepath (both sta
+ [reloadButton_ setMenuEnabled:needReloadMenu];
}
- (void)setStarredState:(BOOL)isStarred {

Powered by Google App Engine
This is Rietveld 408576698