Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 653133003: [Mac] Add menu to reload button available when debugging. (Closed)

Created:
6 years, 2 months ago by dgozman
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac] Add menu to reload button available when debugging. This is already implemented on other platforms. BUG=161567 Committed: https://crrev.com/03490a10d19d3a61e23a61b880eeb62150066478 Cr-Commit-Position: refs/heads/master@{#299674}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -7 lines) Patch
M chrome/app/nibs/Toolbar.xib View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/reload_button.h View 2 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/reload_button.mm View 1 4 chunks +79 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dgozman
Could you please take a look?
6 years, 2 months ago (2014-10-14 16:22:33 UTC) #2
Avi (use Gerrit)
LGTM with minor tweaks https://codereview.chromium.org/653133003/diff/1/chrome/browser/ui/cocoa/toolbar/reload_button.mm File chrome/browser/ui/cocoa/toolbar/reload_button.mm (right): https://codereview.chromium.org/653133003/diff/1/chrome/browser/ui/cocoa/toolbar/reload_button.mm#newcode221 chrome/browser/ui/cocoa/toolbar/reload_button.mm:221: NSString* title = l10n_util::FixUpWindowsStyleLabel(title16); Replace ...
6 years, 2 months ago (2014-10-14 16:42:57 UTC) #3
vsevik
devtools-wise lgtm. https://codereview.chromium.org/653133003/diff/1/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm File chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm (right): https://codereview.chromium.org/653133003/diff/1/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm#newcode446 chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:446: BOOL needReloadMenu = chrome::IsDebuggerAttachedToCurrentTab(browser_); Just to clarify: ...
6 years, 2 months ago (2014-10-14 19:53:37 UTC) #4
dgozman
https://codereview.chromium.org/653133003/diff/1/chrome/browser/ui/cocoa/toolbar/reload_button.mm File chrome/browser/ui/cocoa/toolbar/reload_button.mm (right): https://codereview.chromium.org/653133003/diff/1/chrome/browser/ui/cocoa/toolbar/reload_button.mm#newcode221 chrome/browser/ui/cocoa/toolbar/reload_button.mm:221: NSString* title = l10n_util::FixUpWindowsStyleLabel(title16); On 2014/10/14 16:42:57, Avi wrote: ...
6 years, 2 months ago (2014-10-15 10:20:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653133003/20001
6 years, 2 months ago (2014-10-15 10:22:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-15 11:16:31 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 11:17:11 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/03490a10d19d3a61e23a61b880eeb62150066478
Cr-Commit-Position: refs/heads/master@{#299674}

Powered by Google App Engine
This is Rietveld 408576698