Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 653083003: nanobench: flush after recording every Nth data point. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

nanobench: flush after recording every Nth data point. Got to keep our precious data in event of a crash. With --flushEvery 10 I'm not seeing this cost any wall time. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e070c2bf54c451f0126d4ffb3a48bffe1fbfa437

Patch Set 1 #

Patch Set 2 : --flushEvery #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M bench/ResultsWriter.h View 3 chunks +11 lines, -3 lines 0 comments Download
M bench/nanobench.cpp View 1 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein
6 years, 2 months ago (2014-10-14 15:19:52 UTC) #2
jcgregorio
On 2014/10/14 15:19:52, mtklein wrote: LGTM
6 years, 2 months ago (2014-10-14 15:26:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653083003/20001
6 years, 2 months ago (2014-10-14 15:29:18 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 15:40:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as e070c2bf54c451f0126d4ffb3a48bffe1fbfa437

Powered by Google App Engine
This is Rietveld 408576698