Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: runtime/vm/flow_graph.cc

Issue 653073002: Fix bug with captured parameters and optimized try-catch. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph.h ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph.cc
===================================================================
--- runtime/vm/flow_graph.cc (revision 41095)
+++ runtime/vm/flow_graph.cc (working copy)
@@ -41,7 +41,9 @@
loop_headers_(NULL),
loop_invariant_loads_(NULL),
guarded_fields_(builder.guarded_fields()),
- deferred_prefixes_(builder.deferred_prefixes()) {
+ deferred_prefixes_(builder.deferred_prefixes()),
+ captured_parameters_(
+ new(isolate_) BitVector(isolate_, variable_count())) {
DiscoverBlocks();
}
@@ -959,6 +961,14 @@
if (variable_liveness->IsLastLoad(block_entry, load)) {
(*env)[index] = constant_dead();
}
+
+ // Record captured parameters so that they can be skipped when
+ // emitting sync code inside optimized try-blocks.
+ if (load->local().is_captured_parameter()) {
+ intptr_t index = load->local().BitIndexIn(num_non_copied_params_);
+ captured_parameters_->Add(index);
+ }
+
} else if (push != NULL) {
result = push->value()->definition();
env->Add(result);
« no previous file with comments | « runtime/vm/flow_graph.h ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698