Source/core/html/HTMLObjectElement.cpp - Issue 65303008: Have ElementTraversal::firstWithin() take a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLObjectElement.cpp

Issue 65303008: Have ElementTraversal::firstWithin() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLObjectElement.cpp

diff --git a/Source/core/html/HTMLObjectElement.cpp b/Source/core/html/HTMLObjectElement.cpp

index c0ab271e2a29ca37110847f6b77b0f40a61ec9de..ea508d9815e88c2aedff06805c23af85ce3f3035 100644

--- a/Source/core/html/HTMLObjectElement.cpp

+++ b/Source/core/html/HTMLObjectElement.cpp

@@ -391,7 +391,7 @@ bool HTMLObjectElement::containsJavaApplet() const

if (MIMETypeRegistry::isJavaAppletMIMEType(getAttribute(typeAttr)))

return true;

- for (Element* child = ElementTraversal::firstWithin(this); child; child = ElementTraversal::nextSkippingChildren(child, this)) {

+ for (Element* child = ElementTraversal::firstWithin(*this); child; child = ElementTraversal::nextSkippingChildren(child, this)) {

if (child->hasTagName(paramTag)

&& equalIgnoringCase(child->getNameAttribute(), "type")

&& MIMETypeRegistry::isJavaAppletMIMEType(child->getAttribute(valueAttr).string()))

« Source/core/dom/TreeScope.cpp ('K') | « Source/core/html/HTMLNameCollection.cpp ('k') | Source/core/html/HTMLSelectElement.cpp » ('j') | no next file with comments »