Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: Source/core/html/HTMLNameCollection.cpp

Issue 65303008: Have ElementTraversal::firstWithin() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLFieldSetElement.cpp ('k') | Source/core/html/HTMLObjectElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2011, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2011, 2012 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 ownerNode()->nodeLists()->removeCacheWithAtomicName(this, type(), m_name); 47 ownerNode()->nodeLists()->removeCacheWithAtomicName(this, type(), m_name);
48 } 48 }
49 49
50 Element* HTMLNameCollection::virtualItemAfter(unsigned& offsetInArray, Element* previous) const 50 Element* HTMLNameCollection::virtualItemAfter(unsigned& offsetInArray, Element* previous) const
51 { 51 {
52 ASSERT_UNUSED(offsetInArray, !offsetInArray); 52 ASSERT_UNUSED(offsetInArray, !offsetInArray);
53 ASSERT(previous != ownerNode()); 53 ASSERT(previous != ownerNode());
54 54
55 Element* current; 55 Element* current;
56 if (!previous) 56 if (!previous)
57 current = ElementTraversal::firstWithin(ownerNode()); 57 current = ElementTraversal::firstWithin(*ownerNode());
58 else 58 else
59 current = ElementTraversal::next(*previous, ownerNode()); 59 current = ElementTraversal::next(*previous, ownerNode());
60 60
61 for (; current; current = ElementTraversal::next(*current, ownerNode())) { 61 for (; current; current = ElementTraversal::next(*current, ownerNode())) {
62 switch (type()) { 62 switch (type()) {
63 case WindowNamedItems: 63 case WindowNamedItems:
64 // find only images, forms, applets, embeds and objects by name, 64 // find only images, forms, applets, embeds and objects by name,
65 // but anything by id 65 // but anything by id
66 if (current->hasTagName(imgTag) 66 if (current->hasTagName(imgTag)
67 || current->hasTagName(formTag) 67 || current->hasTagName(formTag)
(...skipping 23 matching lines...) Expand all
91 break; 91 break;
92 default: 92 default:
93 ASSERT_NOT_REACHED(); 93 ASSERT_NOT_REACHED();
94 } 94 }
95 } 95 }
96 96
97 return 0; 97 return 0;
98 } 98 }
99 99
100 } 100 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLFieldSetElement.cpp ('k') | Source/core/html/HTMLObjectElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698