Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: Source/core/svg/SVGElement.cpp

Issue 65303008: Have ElementTraversal::firstWithin() take a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org> 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde .org>
3 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
4 * Copyright (C) 2008 Apple Inc. All rights reserved. 4 * Copyright (C) 2008 Apple Inc. All rights reserved.
5 * Copyright (C) 2008 Alp Toker <alp@atoker.com> 5 * Copyright (C) 2008 Alp Toker <alp@atoker.com>
6 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au> 6 * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
256 256
257 // If the <use> title is not empty we found the title to use. 257 // If the <use> title is not empty we found the title to use.
258 String useTitle(useElement->title()); 258 String useTitle(useElement->title());
259 if (!useTitle.isEmpty()) 259 if (!useTitle.isEmpty())
260 return useTitle; 260 return useTitle;
261 } 261 }
262 } 262 }
263 263
264 // If we aren't an instance in a <use> or the <use> title was not found, the n find the first 264 // If we aren't an instance in a <use> or the <use> title was not found, the n find the first
265 // <title> child of this element. 265 // <title> child of this element.
266 Element* titleElement = ElementTraversal::firstWithin(this); 266 Element* titleElement = ElementTraversal::firstWithin(*this);
267 for (; titleElement; titleElement = ElementTraversal::nextSkippingChildren(t itleElement, this)) { 267 for (; titleElement; titleElement = ElementTraversal::nextSkippingChildren(t itleElement, this)) {
268 if (titleElement->hasTagName(SVGNames::titleTag) && titleElement->isSVGE lement()) 268 if (titleElement->hasTagName(SVGNames::titleTag) && titleElement->isSVGE lement())
269 break; 269 break;
270 } 270 }
271 271
272 // If a title child was found, return the text contents. 272 // If a title child was found, return the text contents.
273 if (titleElement) 273 if (titleElement)
274 return titleElement->innerText(); 274 return titleElement->innerText();
275 275
276 // Otherwise return a null/empty string. 276 // Otherwise return a null/empty string.
(...skipping 907 matching lines...) Expand 10 before | Expand all | Expand 10 after
1184 } 1184 }
1185 1185
1186 if (name == classAttr) 1186 if (name == classAttr)
1187 return true; 1187 return true;
1188 1188
1189 return animatableAttributes.contains(name); 1189 return animatableAttributes.contains(name);
1190 } 1190 }
1191 #endif 1191 #endif
1192 1192
1193 } 1193 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698