Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 65303003: As promised, add a unit test that makes sure the in app payments app gets installed and is enabled. (Closed)

Created:
7 years, 1 month ago by Marijn Kruisselbrink
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

As promised, add a unit test that makes sure the in app payments app gets installed and is enabled. BUG=313797 R=asargent@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235206

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : disable test on android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -6 lines) Patch
M build/android/pylib/gtest/filter/unit_tests_disabled View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
A chrome/browser/extensions/external_provider_impl_unittest.cc View 1 chunk +124 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Marijn Kruisselbrink
7 years, 1 month ago (2013-11-08 00:16:52 UTC) #1
Marijn Kruisselbrink
ping
7 years, 1 month ago (2013-11-13 19:16:57 UTC) #2
asargent_no_longer_on_chrome
lgtm, sorry this fell off my radar
7 years, 1 month ago (2013-11-13 22:19:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/65303003/80001
7 years, 1 month ago (2013-11-13 23:14:11 UTC) #4
commit-bot: I haz the power
Failed to trigger a try job on android_dbg HTTP Error 400: Bad Request
7 years, 1 month ago (2013-11-14 00:34:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/65303003/290001
7 years, 1 month ago (2013-11-14 00:36:19 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=36110
7 years, 1 month ago (2013-11-14 01:13:39 UTC) #7
Marijn Kruisselbrink
7 years, 1 month ago (2013-11-14 19:18:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r235206 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698