Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: src/object-observe.js

Issue 653023004: Work in progress: allow pause-on-exceptions to work in Object.observe callbacks (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.cc ('k') | src/runtime/runtime-debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/object-observe.js
diff --git a/src/object-observe.js b/src/object-observe.js
index 3af2d512075c15bb4294970ab7eadf8a92a886ab..d034bd0912b9e127f2219e45bfd13c21306ae6c2 100644
--- a/src/object-observe.js
+++ b/src/object-observe.js
@@ -571,8 +571,13 @@ function CallbackDeliverPending(callback) {
%MoveArrayContents(callbackInfo, delivered);
try {
+ %DebugPushPromise(null);
aandrey 2014/10/30 10:53:01 But should not we patch Isolate::DoThrow() instead
%_CallFunction(UNDEFINED, delivered, callback);
- } catch (ex) {} // TODO(rossberg): perhaps log uncaught exceptions.
+ } catch (ex) {
+ // TODO(rossberg): perhaps log uncaught exceptions.
+ } finally {
+ %DebugPopPromise();
+ }
return true;
}
« no previous file with comments | « src/isolate.cc ('k') | src/runtime/runtime-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698