Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: src/isolate.cc

Issue 653023004: Work in progress: allow pause-on-exceptions to work in Object.observe callbacks (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.h ('k') | src/object-observe.js » ('j') | src/object-observe.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 59fa038f8d9eccbec389f3698f7a1ae180fa6167..2cc0f80e4e3dff61656caf09dfbf7e3c632adb74 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -1390,12 +1390,11 @@ bool Isolate::OptionalRescheduleException(bool is_bottom_call) {
}
-void Isolate::PushPromise(Handle<JSObject> promise) {
+void Isolate::PushPromise(Handle<Object> promise) {
ThreadLocalTop* tltop = thread_local_top();
PromiseOnStack* prev = tltop->promise_on_stack_;
StackHandler* handler = StackHandler::FromAddress(Isolate::handler(tltop));
- Handle<JSObject> global_handle =
- Handle<JSObject>::cast(global_handles()->Create(*promise));
+ Handle<Object> global_handle = global_handles()->Create(*promise);
tltop->promise_on_stack_ = new PromiseOnStack(handler, global_handle, prev);
}
« no previous file with comments | « src/isolate.h ('k') | src/object-observe.js » ('j') | src/object-observe.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698