Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: src/debug.cc

Issue 653023004: Work in progress: allow pause-on-exceptions to work in Object.observe callbacks (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/isolate.h » ('j') | src/object-observe.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug.cc
diff --git a/src/debug.cc b/src/debug.cc
index 4a58766e53d340c551e1d8925437e5367b212ffe..b1193582eb91cee899ffc9eb776a126dee08c03a 100644
--- a/src/debug.cc
+++ b/src/debug.cc
@@ -2558,6 +2558,8 @@ void Debug::OnException(Handle<Object> exception, bool uncaught,
isolate_, has_reject_handler,
PromiseHasUserDefinedRejectHandler(jspromise), /* void */);
uncaught = has_reject_handler->IsFalse();
+ } else if (!uncaught && promise->IsNull()) {
+ uncaught = true;
}
// Bail out if exception breaks are not active
if (uncaught) {
« no previous file with comments | « no previous file | src/isolate.h » ('j') | src/object-observe.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698