Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 653023003: Try out SkTree in nanobench. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Try out SkTree in nanobench. Looks like a fairly large recording speed win with no playback cost. BUG=skia: Committed: https://skia.googlesource.com/skia/+/6838d854a87e79f1fbb7b89b9f395155ad44dc0a

Patch Set 1 #

Total comments: 2

Patch Set 2 : SkRTree instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -18 lines) Patch
M bench/RecordingBench.cpp View 1 2 chunks +1 line, -8 lines 0 comments Download
M bench/SKPBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/nanobench.cpp View 1 4 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mtklein
6 years, 1 month ago (2014-10-29 20:14:06 UTC) #2
mtklein
Heya, sorry if you've started looking at this. Seemed to make more sense to start ...
6 years, 1 month ago (2014-10-29 20:43:42 UTC) #3
robertphillips
https://codereview.chromium.org/653023003/diff/1/src/core/SkBruteBBH.cpp File src/core/SkBruteBBH.cpp (right): https://codereview.chromium.org/653023003/diff/1/src/core/SkBruteBBH.cpp#newcode1 src/core/SkBruteBBH.cpp:1: #include "SkBruteBBH.h" header! https://codereview.chromium.org/653023003/diff/1/src/core/SkBruteBBH.h File src/core/SkBruteBBH.h (right): https://codereview.chromium.org/653023003/diff/1/src/core/SkBruteBBH.h#newcode1 src/core/SkBruteBBH.h:1: ...
6 years, 1 month ago (2014-10-29 20:48:11 UTC) #4
mtklein
On 2014/10/29 20:48:11, robertphillips wrote: > https://codereview.chromium.org/653023003/diff/1/src/core/SkBruteBBH.cpp > File src/core/SkBruteBBH.cpp (right): > > https://codereview.chromium.org/653023003/diff/1/src/core/SkBruteBBH.cpp#newcode1 > ...
6 years, 1 month ago (2014-10-29 20:51:14 UTC) #5
robertphillips
lgtm
6 years, 1 month ago (2014-10-29 20:53:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653023003/20001
6 years, 1 month ago (2014-10-29 20:58:06 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 21:15:14 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 6838d854a87e79f1fbb7b89b9f395155ad44dc0a

Powered by Google App Engine
This is Rietveld 408576698