Source/core/dom/Element.cpp - Issue 653023002: ASSERTION FAILED: factor > 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 653023002: ASSERTION FAILED: factor > 0 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index 47c62a809afdd5c88b0cf10b0e9bf2bcc220baaa..f3316e29e58bfa019d6780d96364be73f2372462 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -2743,7 +2743,9 @@ inline void Element::updateId(const AtomicString& oldId, const AtomicString& new

inline void Element::updateId(TreeScope& scope, const AtomicString& oldId, const AtomicString& newId)

{

- ASSERT(isInTreeScope());

+ if (!isInTreeScope())

+ return;

ASSERT(oldId != newId);

if (!oldId.isEmpty())