ASSERTION FAILED: factor > 0

Source/core/html/HTMLImageElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 288 matching lines @@
         String type = source->fastGetAttribute(typeAttr);
         if (!type.isEmpty() && !supportedImageType(type))
             continue;
 
         if (!source->mediaQueryMatches())
             continue;
 
         String sizes = source->fastGetAttribute(sizesAttr);
         if (!sizes.isNull())
             UseCounter::count(document(), UseCounter::Sizes);
-        SizesAttributeParser parser = SizesAttributeParser(MediaValuesDynamic::create(document()), sizes);
+        bool hasLocalFrame = document().frame() ? true : false;

[adamk, 2014/10/14 22:43:07]

To answer Ojan's question, this is exactly the reason images "don't load" in
templates.

Ojan, are you asking for this check to move further up?

[ojan, 2014/10/14 22:46:09]

I don't know the code here well enough to know what the right thing to do is,
but at first blush, it seems to me like we shouldn't parse sizes on images in
templates. We'll reparse when we stamp out the new image, right?

[adamk, 2014/10/14 22:48:22]

Sounds like we should reparse when we switch documents (didMoveToNewDocument).

+        SizesAttributeParser parser = SizesAttributeParser(MediaValuesDynamic::create(document()), sizes, hasLocalFrame);
         float effectiveSize = parser.length();
         m_effectiveSizeViewportDependant = parser.viewportDependant();
         ImageCandidate candidate = bestFitSourceForSrcsetAttribute(document().devicePixelRatio(), effectiveSize, source->fastGetAttribute(srcsetAttr));
         if (candidate.isEmpty())
             continue;
         return candidate;
     }
     return ImageCandidate();
 }
 
@@ skipping 313 matching lines @@
             foundURL = true;
         }
     }
 
     if (!foundURL) {
         float effectiveSize = 0;
         if (RuntimeEnabledFeatures::pictureSizesEnabled()) {
             String sizes = fastGetAttribute(sizesAttr);
             if (!sizes.isNull())
                 UseCounter::count(document(), UseCounter::Sizes);
-            SizesAttributeParser parser = SizesAttributeParser(MediaValuesDynamic::create(document()), sizes);
+            bool hasLocalFrame = document().frame() ? true : false;
+            SizesAttributeParser parser = SizesAttributeParser(MediaValuesDynamic::create(document()), sizes, hasLocalFrame);
             effectiveSize = parser.length();
             m_effectiveSizeViewportDependant = parser.viewportDependant();
         }
         ImageCandidate candidate = bestFitSourceForImageAttributes(document().devicePixelRatio(), effectiveSize, fastGetAttribute(srcAttr), fastGetAttribute(srcsetAttr));
         setBestFitURLAndDPRFromImageCandidate(candidate);
     }
     if (m_intrinsicSizingViewportDependant && m_effectiveSizeViewportDependant && !m_listener) {
         m_listener = ViewportChangeListener::create(this);
         document().mediaQueryMatcher().addViewportListener(m_listener);
     }
     imageLoader().updateFromElement(behavior);
 }
 
 const KURL& HTMLImageElement::sourceURL() const
 {
     return cachedImage()->response().url();
 }
 
 }