chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 652983005: mac: Fix bug where exiting tab fullscreen would cause Chrome menubar to disappear.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 652983005: mac: Fix bug where exiting tab fullscreen would cause Chrome menubar to disappear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unit test. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index 440d51345869d492669b02ff67d3ff3b798f752b..d0311651128e30f8cfd5a5b5cf9f748056bca292 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -620,6 +620,11 @@ void BrowserWindowCocoa::EnterFullscreenWithChrome() {

[controller_ enterFullscreenWithChrome];

}

+void BrowserWindowCocoa::EnterFullscreenWithoutChrome() {

+ CHECK(chrome::mac::SupportsSystemFullscreen());

+ [controller_ enterPresentationMode];

bool BrowserWindowCocoa::IsFullscreenWithChrome() {

return IsFullscreen() && ![controller_ inPresentationMode];

}

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.h ('k') | chrome/browser/ui/fullscreen/fullscreen_controller.cc » ('j') | no next file with comments »