Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 652983005: mac: Fix bug where exiting tab fullscreen would cause Chrome menubar to disappear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index 3874f2005a146a1393b43bd605710d18c9cbd265..15d46274449b4c845eed3b867196129bcb3d1b49 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -490,13 +490,10 @@ willPositionSheet:(NSWindow*)sheet
}
- (void)adjustUIForSlidingFullscreenStyle:(fullscreen_mac::SlidingStyle)style {
- if (!presentationModeController_) {
- presentationModeController_.reset(
- [self newPresentationModeControllerWithStyle:style]);
- [self configurePresentationModeController];
- } else {
- presentationModeController_.get().slidingStyle = style;
- }
+ [presentationModeController_ exitPresentationMode];
Robert Sesek 2014/10/15 20:28:14 I don't follow this...
erikchen 2014/10/15 21:50:35 presentationModeController_.get().slidingStyle = s
+ presentationModeController_.reset(
+ [self newPresentationModeControllerWithStyle:style]);
+ [self configurePresentationModeController];
if (!floatingBarBackingView_.get() &&
([self hasTabStrip] || [self hasToolbar] || [self hasLocationBar])) {
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/fullscreen/fullscreen_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698