Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: chrome/browser/ui/browser_window.h

Issue 652983005: mac: Fix bug where exiting tab fullscreen would cause Chrome menubar to disappear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit test. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_WINDOW_H_
6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 6 #define CHROME_BROWSER_UI_BROWSER_WINDOW_H_
7 7
8 #include "base/callback_forward.h" 8 #include "base/callback_forward.h"
9 #include "chrome/browser/lifetime/browser_close_manager.h" 9 #include "chrome/browser/lifetime/browser_close_manager.h"
10 #include "chrome/browser/signin/signin_header_helper.h" 10 #include "chrome/browser/signin/signin_header_helper.h"
(...skipping 295 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 // if the renderer did not process it. 306 // if the renderer did not process it.
307 virtual void HandleKeyboardEvent( 307 virtual void HandleKeyboardEvent(
308 const content::NativeWebKeyboardEvent& event) = 0; 308 const content::NativeWebKeyboardEvent& event) = 0;
309 309
310 // Clipboard commands applied to the whole browser window. 310 // Clipboard commands applied to the whole browser window.
311 virtual void Cut() = 0; 311 virtual void Cut() = 0;
312 virtual void Copy() = 0; 312 virtual void Copy() = 0;
313 virtual void Paste() = 0; 313 virtual void Paste() = 0;
314 314
315 #if defined(OS_MACOSX) 315 #if defined(OS_MACOSX)
316 // Enters Mac specific fullscreen mode with chrome displayed (e.g. omnibox) 316 // The following two methods cause the browser window to enter AppKit
317 // on OSX 10.7+, a.k.a. Lion Fullscreen mode. 317 // Fullscreen. The methods are idempotent. The methods are invalid to call on
318 // Invalid to call on OSX earlier than 10.7. 318 // OSX 10.6. One method displays chrome (e.g. omnibox, tabstrip), whereas the
319 // Enters either from non fullscreen, or from fullscreen without chrome. 319 // other method hides it.
320 // Exit to normal fullscreen with EnterFullscreen().
321 virtual void EnterFullscreenWithChrome() = 0; 320 virtual void EnterFullscreenWithChrome() = 0;
321 virtual void EnterFullscreenWithoutChrome() = 0;
322
322 virtual bool IsFullscreenWithChrome() = 0; 323 virtual bool IsFullscreenWithChrome() = 0;
323 virtual bool IsFullscreenWithoutChrome() = 0; 324 virtual bool IsFullscreenWithoutChrome() = 0;
324 #endif 325 #endif
325 326
326 // Return the correct disposition for a popup window based on |bounds|. 327 // Return the correct disposition for a popup window based on |bounds|.
327 virtual WindowOpenDisposition GetDispositionForPopupBounds( 328 virtual WindowOpenDisposition GetDispositionForPopupBounds(
328 const gfx::Rect& bounds) = 0; 329 const gfx::Rect& bounds) = 0;
329 330
330 // Construct a FindBar implementation for the |browser|. 331 // Construct a FindBar implementation for the |browser|.
331 virtual FindBar* CreateFindBar() = 0; 332 virtual FindBar* CreateFindBar() = 0;
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
389 virtual void ExecuteExtensionCommand(const extensions::Extension* extension, 390 virtual void ExecuteExtensionCommand(const extensions::Extension* extension,
390 const extensions::Command& command) = 0; 391 const extensions::Command& command) = 0;
391 392
392 protected: 393 protected:
393 friend class BrowserCloseManager; 394 friend class BrowserCloseManager;
394 friend class BrowserView; 395 friend class BrowserView;
395 virtual void DestroyBrowser() = 0; 396 virtual void DestroyBrowser() = 0;
396 }; 397 };
397 398
398 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_ 399 #endif // CHROME_BROWSER_UI_BROWSER_WINDOW_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/browser_window_cocoa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698