content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java - Issue 652953008: Navigation transitions (web to native app): Pass data after starting provisional load (Chrome side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 652953008: Navigation transitions (web to native app): Pass data after starting provisional load (Chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review fix Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/android/java/src/org/chromium/content_public/browser/NavigationTransitionDelegate.java » ('j') | content/public/android/java/src/org/chromium/content_public/browser/NavigationTransitionDelegate.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

index 9cd3f0f836e4293b555ec09fedd5fbf9a41124fe..611eb89cfab03d5e04548b534f1867b7ba8c0426 100644

--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

@@ -210,9 +210,18 @@ import org.chromium.content_public.browser.WebContents;

}

@CalledByNative

- private void didStartNavigationTransitionForFrame(long frameId) {

+ private void didStartNavigationTransitionForFrame(long frameId, String cssSelector) {

if (mNavigationTransitionDelegate != null) {

- mNavigationTransitionDelegate.didStartNavigationTransitionForFrame(frameId);

+ mNavigationTransitionDelegate.didStartNavigationTransitionForFrame(

+ frameId, cssSelector);

+ }

+ @CalledByNative

+ private void addNavigationTransitionElements(String name, int x, int y, int width, int height) {

+ if (mNavigationTransitionDelegate != null) {

+ mNavigationTransitionDelegate.addNavigationTransitionElements(

+ name, x, y, width, height);

}