content/browser/frame_host/navigator_impl.cc - Issue 652953008: Navigation transitions (web to native app): Pass data after starting provisional load (Chrome side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 652953008: Navigation transitions (web to native app): Pass data after starting provisional load (Chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigator_delegate.h ('k') | content/browser/web_contents/web_contents_android.h » ('j') | content/browser/web_contents/web_contents_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index c5b67b40ad6c2b7f8f9df41354ecff7b2155831a..26352184351d92c1c59091b0eacc041bd921b327 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -255,8 +255,16 @@ void NavigatorImpl::DidStartProvisionalLoad(

delegate_->NotifyChangedNavigationState(content::INVALIDATE_TYPE_URL);

}

- if (delegate_ && is_transition_navigation)

- delegate_->DidStartNavigationTransition(render_frame_host);

+ if (delegate_ && is_transition_navigation) {

+ TransitionLayerData transition_data;

+ TransitionRequestManager::GetInstance()->HasPendingTransitionRequest(

+ render_frame_host->GetProcess()->GetID(),

+ render_frame_host->GetRoutingID(),

+ url,

nasko 2014/10/22 21:10:04 This should be validated_url, not the input parame

Zhen Wang 2014/10/22 23:04:40 Done.

+ &transition_data);

+ delegate_->DidStartNavigationTransition(render_frame_host,

+ transition_data);

+ }

}

if (delegate_) {