Navigation transitions (web to native app): Pass data after starting provisional load (Chrome side)

content/browser/frame_host/navigator_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigator_impl.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/time/time.h"
 #include "content/browser/frame_host/frame_tree.h"
@@ skipping 237 matching lines @@
         entry->set_transferred_global_request_id(
             pending_entry->transferred_global_request_id());
         entry->set_should_replace_entry(pending_entry->should_replace_entry());
         entry->SetRedirectChain(pending_entry->GetRedirectChain());
       }
       controller_->SetPendingEntry(entry);
       if (delegate_)
         delegate_->NotifyChangedNavigationState(content::INVALIDATE_TYPE_URL);
     }
 
-    if (delegate_ && is_transition_navigation)
-      delegate_->DidStartNavigationTransition(render_frame_host);
+    if (delegate_ && is_transition_navigation) {
+      TransitionLayerData transition_data;
+      TransitionRequestManager::GetInstance()->HasPendingTransitionRequest(

[nasko, 2014/10/29 22:14:24]

This method name looks very weird. A Has* method should return a boolean and not
the actual data. Renaming to Get* fits more of how it is actually used here.

[Zhen Wang, 2014/10/29 23:11:05]

Done.

+          render_frame_host->GetProcess()->GetID(),
+          render_frame_host->GetRoutingID(),
+          validated_url,
+          &transition_data);
+      delegate_->DidStartNavigationTransition(render_frame_host,
+                                              transition_data);
+    }
   }
 
   if (delegate_) {
     // Notify the observer about the start of the provisional load.
     delegate_->DidStartProvisionalLoad(
         render_frame_host, validated_url, is_error_page, is_iframe_srcdoc);
   }
 }
 
 
@@ skipping 641 matching lines @@
         "Navigation.TimeToCommit_ExistingRenderer_BeforeUnloadDiscounted",
         time_to_commit);
     UMA_HISTOGRAM_TIMES(
         "Navigation.TimeToURLJobStart_ExistingRenderer_BeforeUnloadDiscounted",
         time_to_network);
   }
   navigation_data_.reset();
 }
 
 }  // namespace content