| Index: src/ia32/ic-ia32.cc
|
| diff --git a/src/ia32/ic-ia32.cc b/src/ia32/ic-ia32.cc
|
| index 489a78b1c46a558063c8cbe7dd409584d2f5a03c..67c38304cbcfc7a1b7a03af7c6d12f15a3555757 100644
|
| --- a/src/ia32/ic-ia32.cc
|
| +++ b/src/ia32/ic-ia32.cc
|
| @@ -710,7 +710,7 @@ void KeyedLoadIC::GenerateString(MacroAssembler* masm) {
|
| char_at_generator.GenerateFast(masm);
|
| __ ret(0);
|
|
|
| - ICRuntimeCallHelper call_helper;
|
| + StubRuntimeCallHelper call_helper;
|
| char_at_generator.GenerateSlow(masm, call_helper);
|
|
|
| __ bind(&miss);
|
| @@ -1632,16 +1632,15 @@ void LoadIC::GenerateMiss(MacroAssembler* masm) {
|
| }
|
|
|
|
|
| -// One byte opcode for test eax,0xXXXXXXXX.
|
| -static const byte kTestEaxByte = 0xA9;
|
| -
|
| bool LoadIC::PatchInlinedLoad(Address address, Object* map, int offset) {
|
| + if (V8::UseCrankshaft()) return false;
|
| +
|
| // The address of the instruction following the call.
|
| Address test_instruction_address =
|
| address + Assembler::kCallTargetAddressOffset;
|
| // If the instruction following the call is not a test eax, nothing
|
| // was inlined.
|
| - if (*test_instruction_address != kTestEaxByte) return false;
|
| + if (*test_instruction_address != Assembler::kTestEaxByte) return false;
|
|
|
| Address delta_address = test_instruction_address + 1;
|
| // The delta to the start of the map check instruction.
|
| @@ -1685,6 +1684,8 @@ bool LoadIC::PatchInlinedContextualLoad(Address address,
|
| Object* map,
|
| Object* cell,
|
| bool is_dont_delete) {
|
| + if (V8::UseCrankshaft()) return false;
|
| +
|
| // The address of the instruction following the call.
|
| Address mov_instruction_address =
|
| address + Assembler::kCallTargetAddressOffset;
|
| @@ -1716,13 +1717,15 @@ bool LoadIC::PatchInlinedContextualLoad(Address address,
|
|
|
|
|
| bool StoreIC::PatchInlinedStore(Address address, Object* map, int offset) {
|
| + if (V8::UseCrankshaft()) return false;
|
| +
|
| // The address of the instruction following the call.
|
| Address test_instruction_address =
|
| address + Assembler::kCallTargetAddressOffset;
|
|
|
| // If the instruction following the call is not a test eax, nothing
|
| // was inlined.
|
| - if (*test_instruction_address != kTestEaxByte) return false;
|
| + if (*test_instruction_address != Assembler::kTestEaxByte) return false;
|
|
|
| // Extract the encoded deltas from the test eax instruction.
|
| Address encoded_offsets_address = test_instruction_address + 1;
|
| @@ -1762,11 +1765,13 @@ bool StoreIC::PatchInlinedStore(Address address, Object* map, int offset) {
|
|
|
|
|
| static bool PatchInlinedMapCheck(Address address, Object* map) {
|
| + if (V8::UseCrankshaft()) return false;
|
| +
|
| Address test_instruction_address =
|
| address + Assembler::kCallTargetAddressOffset;
|
| // The keyed load has a fast inlined case if the IC call instruction
|
| // is immediately followed by a test instruction.
|
| - if (*test_instruction_address != kTestEaxByte) return false;
|
| + if (*test_instruction_address != Assembler::kTestEaxByte) return false;
|
|
|
| // Fetch the offset from the test instruction to the map cmp
|
| // instruction. This offset is stored in the last 4 bytes of the 5
|
| @@ -1963,6 +1968,24 @@ void StoreIC::GenerateNormal(MacroAssembler* masm) {
|
| }
|
|
|
|
|
| +void StoreIC::GenerateGlobalProxy(MacroAssembler* masm) {
|
| + // ----------- S t a t e -------------
|
| + // -- eax : value
|
| + // -- ecx : name
|
| + // -- edx : receiver
|
| + // -- esp[0] : return address
|
| + // -----------------------------------
|
| + __ pop(ebx);
|
| + __ push(edx);
|
| + __ push(ecx);
|
| + __ push(eax);
|
| + __ push(ebx);
|
| +
|
| + // Do tail-call to runtime routine.
|
| + __ TailCallRuntime(Runtime::kSetProperty, 3, 1);
|
| +}
|
| +
|
| +
|
| // Defined in ic.cc.
|
| Object* KeyedStoreIC_Miss(Arguments args);
|
|
|
| @@ -2004,9 +2027,59 @@ void KeyedStoreIC::GenerateMiss(MacroAssembler* masm) {
|
| __ TailCallExternalReference(ref, 3, 1);
|
| }
|
|
|
| +
|
| #undef __
|
|
|
|
|
| +Condition CompareIC::ComputeCondition(Token::Value op) {
|
| + switch (op) {
|
| + case Token::EQ_STRICT:
|
| + case Token::EQ:
|
| + return equal;
|
| + case Token::LT:
|
| + return less;
|
| + case Token::GT:
|
| + // Reverse left and right operands to obtain ECMA-262 conversion order.
|
| + return less;
|
| + case Token::LTE:
|
| + // Reverse left and right operands to obtain ECMA-262 conversion order.
|
| + return greater_equal;
|
| + case Token::GTE:
|
| + return greater_equal;
|
| + default:
|
| + UNREACHABLE();
|
| + return no_condition;
|
| + }
|
| +}
|
| +
|
| +
|
| +void CompareIC::UpdateCaches(Handle<Object> x, Handle<Object> y) {
|
| + HandleScope scope;
|
| + Handle<Code> rewritten;
|
| +#ifdef DEBUG
|
| + State previous_state = GetState();
|
| +#endif
|
| + State state = TargetState(x, y);
|
| + if (state == GENERIC) {
|
| + CompareStub stub(GetCondition(), strict(), NO_COMPARE_FLAGS);
|
| + rewritten = stub.GetCode();
|
| + } else {
|
| + ICCompareStub stub(op_, state);
|
| + rewritten = stub.GetCode();
|
| + }
|
| + set_target(*rewritten);
|
| +
|
| +#ifdef DEBUG
|
| + if (FLAG_trace_ic) {
|
| + PrintF("[CompareIC (%s->%s)#%s]\n",
|
| + GetStateName(previous_state),
|
| + GetStateName(state),
|
| + Token::Name(op_));
|
| + }
|
| +#endif
|
| +}
|
| +
|
| +
|
| } } // namespace v8::internal
|
|
|
| #endif // V8_TARGET_ARCH_IA32
|
|
|