Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: pkg/analysis_server/lib/src/operation/operation_analysis.dart

Issue 652903006: Issue 21373. Fix for removing line info in case of exception (causes NPE in outline computer). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/computer/computer_outline.dart ('k') | pkg/analysis_server/pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/operation/operation_analysis.dart
diff --git a/pkg/analysis_server/lib/src/operation/operation_analysis.dart b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
index d9e46f24e35540fcd8d3a7f22ce30e74beb8f6e2..12af380c2309ad1dab841d7526eda2fd1b1510cd 100644
--- a/pkg/analysis_server/lib/src/operation/operation_analysis.dart
+++ b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
@@ -49,9 +49,9 @@ void sendAnalysisNotificationOccurrences(AnalysisServer server, String file,
void sendAnalysisNotificationOutline(AnalysisServer server,
- AnalysisContext context, Source source, CompilationUnit dartUnit) {
+ Source source, LineInfo lineInfo, CompilationUnit dartUnit) {
server.sendNotification(new protocol.AnalysisOutlineParams(source.fullName,
- new DartUnitOutlineComputer(context, source,
+ new DartUnitOutlineComputer(source, lineInfo,
dartUnit).compute()).toNotification());
}
@@ -127,7 +127,8 @@ class PerformAnalysisOperation extends ServerOperation {
sendAnalysisNotificationOccurrences(server, file, dartUnit);
}
if (server.hasAnalysisSubscription(protocol.AnalysisService.OUTLINE, file)) {
- sendAnalysisNotificationOutline(server, context, source, dartUnit);
+ LineInfo lineInfo = notice.lineInfo;
+ sendAnalysisNotificationOutline(server, source, lineInfo, dartUnit);
}
if (server.hasAnalysisSubscription(protocol.AnalysisService.OVERRIDES, file)) {
sendAnalysisNotificationOverrides(server, file, dartUnit);
« no previous file with comments | « pkg/analysis_server/lib/src/computer/computer_outline.dart ('k') | pkg/analysis_server/pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698