Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 652903005: Revert of Remove raw handles from base::win::RegKey (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, mmenke, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove raw handles from base::win::RegKey (patchset #6 id:330001 of https://codereview.chromium.org/632833002/) Reason for revert: Causing base_unittests failures on XP Tests (1) Original issue's description: > Remove raw handles from base::win::RegKey > > BUG=419210, 423634 > R=cpu@chromium.org, eroman@chromium.org, sky@chromium.org > > Committed: https://crrev.com/1aa0fa75b65f403e08ae0f3f2fcb053c02cd9ef2 > Cr-Commit-Position: refs/heads/master@{#299737} TBR=cpu@chromium.org,eroman@chromium.org,jam@chromium.org,rvargas@chromium.org NOTREECHECKS=true NOTRY=true BUG=419210, 423634 Committed: https://crrev.com/4fe6ccadfda8e661ef22a5ab1ce4702f4d363d36 Cr-Commit-Position: refs/heads/master@{#299828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -213 lines) Patch
M base/win/registry.h View 4 chunks +14 lines, -14 lines 0 comments Download
M base/win/registry.cc View 4 chunks +51 lines, -70 lines 0 comments Download
M base/win/registry_unittest.cc View 2 chunks +0 lines, -65 lines 0 comments Download
M content/browser/plugin_service_impl.h View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 3 chunks +34 lines, -13 lines 0 comments Download
M net/dns/dns_config_service_win.cc View 4 chunks +23 lines, -17 lines 0 comments Download
M net/proxy/proxy_config_service_win.h View 4 chunks +10 lines, -12 lines 0 comments Download
M net/proxy/proxy_config_service_win.cc View 4 chunks +43 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of Remove raw handles from base::win::RegKey
6 years, 2 months ago (2014-10-16 03:05:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652903005/1
6 years, 2 months ago (2014-10-16 03:07:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 03:09:37 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 03:10:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fe6ccadfda8e661ef22a5ab1ce4702f4d363d36
Cr-Commit-Position: refs/heads/master@{#299828}

Powered by Google App Engine
This is Rietveld 408576698