Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 652893005: Look for gclient.py in find_depot_tools (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Look for gclient.py in find_depot_tools Many (but not all!) of our bots have a directory early in the PATH that contains nothing but a script called 'gclient' and have the real depot_tools directory later on in the path. This looks for gclient.py, which is in the real depot_tools directory. Committed: https://crrev.com/380a535523ed8b808eab6fa7c205dce67e0ed2a9 Cr-Commit-Position: refs/heads/master@{#300802}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/find_depot_tools.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jamesr
6 years, 1 month ago (2014-10-22 22:20:03 UTC) #2
scottmg
lgtm
6 years, 1 month ago (2014-10-22 22:49:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652893005/1
6 years, 1 month ago (2014-10-22 22:51:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-23 00:02:51 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-23 00:03:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/380a535523ed8b808eab6fa7c205dce67e0ed2a9
Cr-Commit-Position: refs/heads/master@{#300802}

Powered by Google App Engine
This is Rietveld 408576698