Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 652873002: Disable NaClBrowserTestGLibcVcacheExtension.ValidationCacheOfMainNexe on ARM. (Closed)

Created:
6 years, 2 months ago by Sam Clegg
Modified:
6 years, 2 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable NaClBrowserTestGLibcVcacheExtension.ValidationCacheOfMainNexe on ARM. NaCl does not support glibc on ARM so all glibc-related tests should be disabled on ARM. BUG=422592 TEST=linux_arm trybot Committed: https://crrev.com/7c8d1ab8e83a2aa5a635b3e77cdf02b7297692ca Cr-Commit-Position: refs/heads/master@{#299808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/nacl/nacl_browsertest_uma.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam Clegg
6 years, 2 months ago (2014-10-13 21:45:13 UTC) #2
Mark Seaborn
"doesn't not" -> "does not". LGTM.
6 years, 2 months ago (2014-10-13 22:04:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652873002/1
6 years, 2 months ago (2014-10-15 23:35:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 01:23:15 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 01:23:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c8d1ab8e83a2aa5a635b3e77cdf02b7297692ca
Cr-Commit-Position: refs/heads/master@{#299808}

Powered by Google App Engine
This is Rietveld 408576698