Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 652813005: DevTools: Extenstions: use request.contentEncoded for GetRequestContent (Closed)

Created:
6 years, 2 months ago by eustas
Modified:
6 years, 2 months ago
Reviewers:
caseq, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: Extenstions: use request.contentEncoded for GetRequestContent BUG=309710 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184351

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/devtools/front_end/extensions/ExtensionServer.js View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
eustas
6 years, 2 months ago (2014-10-21 12:50:41 UTC) #2
eustas
6 years, 2 months ago (2014-10-22 04:51:40 UTC) #4
vsevik
https://codereview.chromium.org/652813005/diff/1/Source/devtools/front_end/extensions/ExtensionServer.js File Source/devtools/front_end/extensions/ExtensionServer.js (right): https://codereview.chromium.org/652813005/diff/1/Source/devtools/front_end/extensions/ExtensionServer.js#newcode558 Source/devtools/front_end/extensions/ExtensionServer.js:558: encoding: content && request.contentEncoded ? "base64" : "", We ...
6 years, 2 months ago (2014-10-22 14:25:08 UTC) #5
eustas
https://codereview.chromium.org/652813005/diff/1/Source/devtools/front_end/extensions/ExtensionServer.js File Source/devtools/front_end/extensions/ExtensionServer.js (right): https://codereview.chromium.org/652813005/diff/1/Source/devtools/front_end/extensions/ExtensionServer.js#newcode558 Source/devtools/front_end/extensions/ExtensionServer.js:558: encoding: content && request.contentEncoded ? "base64" : "", On ...
6 years, 2 months ago (2014-10-23 13:40:56 UTC) #6
eustas
Ping
6 years, 2 months ago (2014-10-24 05:04:11 UTC) #7
vsevik
https://codereview.chromium.org/652813005/diff/20001/Source/devtools/front_end/extensions/ExtensionServer.js File Source/devtools/front_end/extensions/ExtensionServer.js (right): https://codereview.chromium.org/652813005/diff/20001/Source/devtools/front_end/extensions/ExtensionServer.js#newcode570 Source/devtools/front_end/extensions/ExtensionServer.js:570: contentProvider.requestContent(onContentAvailable.bind(this)); Resource here could actually be a UISourceCode, so ...
6 years, 2 months ago (2014-10-24 05:58:19 UTC) #8
eustas
https://codereview.chromium.org/652813005/diff/20001/Source/devtools/front_end/extensions/ExtensionServer.js File Source/devtools/front_end/extensions/ExtensionServer.js (right): https://codereview.chromium.org/652813005/diff/20001/Source/devtools/front_end/extensions/ExtensionServer.js#newcode570 Source/devtools/front_end/extensions/ExtensionServer.js:570: contentProvider.requestContent(onContentAvailable.bind(this)); On 2014/10/24 05:58:19, vsevik wrote: > Resource here ...
6 years, 2 months ago (2014-10-24 11:15:57 UTC) #9
vsevik
lgtm
6 years, 2 months ago (2014-10-24 11:21:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652813005/40001
6 years, 2 months ago (2014-10-24 11:22:24 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 12:23:24 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 184351

Powered by Google App Engine
This is Rietveld 408576698