Move speculations pump scheduling logic to HTMLParserScheduler.

Move speculations pump scheduling logic to HTMLParserScheduler.

Before this CL, HTMLDocumentParser pumped speculations with its scheduling
logic inlined into HTMLDocumentParser::pumpPendingSpeculations.
This CL moves the scheduling logic into HTMLParserScheduler.

This CL also adds SpeculationsPumpSession to manage its startTime.
From this change, ActiveParserSession scope was moved from
processParsedChunkFromBackgroundParser to its only caller
pumpPendingSpeculations.

BUG=421300
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184044

[kouhei (in TOK), 2014-10-16 11:05:36]

kouhei@chromium.org changed reviewers:
+ eseidel@chromium.org, haraken@chromium.org, skyostil@google.com

[kouhei (in TOK), 2014-10-16 11:05:37]

Would you take a look?
This moves scheduling logic as suggested in
https://codereview.chromium.org/634983003/

[Sami, 2014-10-16 12:46:25]

skyostil@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2014-10-16 12:46:26]

Thanks, looks like a good cleanup. I'll let Eric lg this.

https://codereview.chromium.org/652813004/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLParserScheduler.cpp (right):

https://codereview.chromium.org/652813004/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLParserScheduler.cpp:123: const double
parserTimeLimit = 0.500;
nit: no need for the trailing zeros.

https://codereview.chromium.org/652813004/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLParserScheduler.h (right):

https://codereview.chromium.org/652813004/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLParserScheduler.h:86: bool shouldYield(const
SpeculationsPumpSession&);
Looks like this could be a const method?

[kouhei (in TOK), 2014-10-16 12:54:19]

Thanks for your comments!

https://codereview.chromium.org/652813004/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLParserScheduler.cpp (right):

https://codereview.chromium.org/652813004/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLParserScheduler.cpp:123: const double
parserTimeLimit = 0.500;
On 2014/10/16 12:46:25, Sami wrote:
> nit: no need for the trailing zeros.

Done.

https://codereview.chromium.org/652813004/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLParserScheduler.h (right):

https://codereview.chromium.org/652813004/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLParserScheduler.h:86: bool shouldYield(const
SpeculationsPumpSession&);
On 2014/10/16 12:46:25, Sami wrote:
> Looks like this could be a const method?

Done.

[kouhei (in TOK), 2014-10-20 00:08:03]

eseidel: Would you take a look?

[kouhei (in TOK), 2014-10-21 02:08:30]

haraken: Would you review this one? Parser scheduling project is currently
blocked by this CL.

[haraken, 2014-10-21 02:14:05]

This CL LGTM

However, I'm not an expert of this area and would love to have another reviewer
in subsequent CLs.

https://codereview.chromium.org/652813004/diff/40001/Source/core/html/parser/...
File Source/core/html/parser/HTMLParserScheduler.h (right):

https://codereview.chromium.org/652813004/diff/40001/Source/core/html/parser/...
Source/core/html/parser/HTMLParserScheduler.h:58:
SpeculationsPumpSession(Document*);

Add explicit.

[kouhei (in TOK), 2014-10-21 05:01:41]

On 2014/10/21 02:14:05, haraken wrote:
> This CL LGTM
> 
> However, I'm not an expert of this area and would love to have another
reviewer
> in subsequent CLs.
> 
>
https://codereview.chromium.org/652813004/diff/40001/Source/core/html/parser/...
> File Source/core/html/parser/HTMLParserScheduler.h (right):
> 
>
https://codereview.chromium.org/652813004/diff/40001/Source/core/html/parser/...
> Source/core/html/parser/HTMLParserScheduler.h:58:
> SpeculationsPumpSession(Document*);
> 
> Add explicit.

Done.

[kouhei (in TOK), 2014-10-21 05:11:34]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-10-21 05:12:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/652813004/60001

[commit-bot: I haz the power, 2014-10-21 06:41:08]

Committed patchset #4 (id:60001) as 184044

[eseidel, 2014-10-21 16:20:39]

lgtm

[kouhei (in TOK), 2014-10-28 11:11:54]

Patchset #5 (id:80001) has been deleted